From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition
Date: Mon, 30 Nov 2015 11:42:22 -0800 [thread overview]
Message-ID: <20151130194222.GH64635@google.com> (raw)
In-Reply-To: <CACna6ryU3AorbbL3f7REVueREHJZMfZpvoZs0ijVj1SNG4Z6ng@mail.gmail.com>
On Sat, Nov 28, 2015 at 03:05:26PM +0100, Rafał Miłecki wrote:
> On 27 November 2015 at 23:33, Brian Norris <computersforpeace@gmail.com> wrote:
> > On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote:
> >> On 26 November 2015 at 09:05, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor")
> >
> > I'm not 100% sure, but I thought I recall the -stable folks picking up
> > for-linus commits just based on the 'Fixes:' tags. I feel like that
> > isn't always ideal, though.
>
> I'm confused. Do you mean I shouldn't include it?
No, the 'Fixes' usage is fine. I'm just not clear what importance is
placed on it by others.
> Do you have a reference to more detailed Fixes usage? All I found is
> info in Documentation/SubmittingPatches:
> > If your patch fixes a bug in a specific commit, e.g. you found an issue using
> > git-bisect, please use the 'Fixes:' tag
> I think 'Fixes' usage is OK in this case.
I don't have any better reference. Perhaps I'm completely mistaken, and
'Fixes' is never taken as the sole source of for-stable annotation.
Brian
next prev parent reply other threads:[~2015-11-30 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 8:05 [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition Rafał Miłecki
2015-11-27 9:25 ` Rafał Miłecki
2015-11-27 22:33 ` Brian Norris
2015-11-28 14:05 ` Rafał Miłecki
2015-11-30 19:42 ` Brian Norris [this message]
2015-11-30 20:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130194222.GH64635@google.com \
--to=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).