From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: fix ONFI parameter page layout
Date: Tue, 1 Dec 2015 20:10:32 +0100 [thread overview]
Message-ID: <20151201201032.551f5562@bbrezillon> (raw)
In-Reply-To: <20151201190510.GY64635@google.com>
On Tue, 1 Dec 2015 11:05:10 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> On Tue, Dec 01, 2015 at 10:33:18AM +0100, Boris Brezillon wrote:
> > On Mon, 30 Nov 2015 12:17:29 -0800
> > Brian Norris <computersforpeace@gmail.com> wrote:
> > > On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote:
> > > > src_ssync_features field is only 1 byte large, and the 4th reserved area
> > > > is actually 8 bytes large.
> > > >
> > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > > > Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device")
> > > > Cc: <stable@vger.kernel.org> #v2.6.37+
> > >
> > > Did you see an actual problem from this? (And is this deserving of
> > > stable?) I could imagine an out-of-tree driver might try to use t_ald
> > > (which should actually be t_adl, right?)
> >
> > Yes, should be t_adl, not t_ald. Do you want me to send another patch
> > for that, or will you take care of it?
>
> I'll send a quick patch.
>
> > > and get the wrong value. But no
> > > one does that in-tree yet.
> >
> > Fair enough, we can just drop the stable and fixes tag. Do you want me
> > to resend it?
>
> I presume this means you didn't see any actual problems caused by this
> patch, other than new development referencing it?
Yep, I noticed the problem when playing with the driver strength
feature.
>
> Applied without the stable tag. I kept the fixes tag.
>
> Thanks,
> Brian
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-01 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 10:23 [PATCH] mtd: nand: fix ONFI parameter page layout Boris Brezillon
2015-11-30 20:17 ` Brian Norris
2015-12-01 9:33 ` Boris Brezillon
2015-12-01 19:05 ` Brian Norris
2015-12-01 19:10 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201201032.551f5562@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).