From: Brian Norris <computersforpeace@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()
Date: Fri, 4 Dec 2015 15:39:25 -0800 [thread overview]
Message-ID: <20151204233925.GH120110@google.com> (raw)
In-Reply-To: <1448104484-22612-1-git-send-email-lars@metafoo.de>
On Sat, Nov 21, 2015 at 12:14:44PM +0100, Lars-Peter Clausen wrote:
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
>
> Patch was generated using the following semantic patch:
> // <smpl>
> @@
> expression irq;
> @@
> -synchronize_irq(irq);
> free_irq(irq, ...);
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to l2-mtd.git
prev parent reply other threads:[~2015-12-04 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 11:14 [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq() Lars-Peter Clausen
2015-12-04 23:39 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204233925.GH120110@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=lars@metafoo.de \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).