From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aGbYi-0007MZ-0n for linux-mtd@lists.infradead.org; Wed, 06 Jan 2016 00:02:36 +0000 Received: by mail-pa0-x22f.google.com with SMTP id uo6so203884837pac.1 for ; Tue, 05 Jan 2016 16:02:13 -0800 (PST) Date: Tue, 5 Jan 2016 16:02:10 -0800 From: Brian Norris To: linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Daniel Kurtz , Marek Vasut , Bayi Cheng , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Felix Fietkau , Eddie Huang =?utf-8?B?KOm7g+aZuuWCkSk=?= , Milton Chiang =?utf-8?B?KOaxn+aYjuaZjyk=?= Subject: Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond) Message-ID: <20160106000210.GJ109450@google.com> References: <1450205301-32207-1-git-send-email-computersforpeace@gmail.com> <20160105022928.GF109450@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160105022928.GF109450@google.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 04, 2016 at 06:29:28PM -0800, Brian Norris wrote: > On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote: > > Spansion and Winbond have occasionally used the same manufacturer ID, > > and they don't support the same features. Particularly, writing SR=0 > > seems to break read access for Spansion's s25fl064k. Unfortunately, we > > don't currently have a way to differentiate these Spansion and Winbond > > parts, so rather than regressing support for these Spansion flash, let's > > drop the new Winbond lock/unlock support for now. We can try to address > > Winbond support during the next release cycle. > > > > Original discussion: > > > > http://patchwork.ozlabs.org/patch/549173/ > > http://patchwork.ozlabs.org/patch/553683/ > > > > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond") > > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup") > > Signed-off-by: Brian Norris > > Reported-by: Felix Fietkau > > Cc: Felix Fietkau > > Felix, > > Can I get a Tested-by? I'm going to send this for 4.4 still, if > possible. Despite the lack of response, pushed both to linux-mtd.git, as they are obvious responses to the reported regressions/bugs. Brian