From: Brian Norris <computersforpeace@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug
Date: Wed, 6 Jan 2016 16:04:10 -0800 [thread overview]
Message-ID: <20160107000410.GR109450@google.com> (raw)
In-Reply-To: <87lh8qhbqp.fsf@belgarion.home>
On Sat, Dec 19, 2015 at 01:19:26PM +0100, Robert Jarzmik wrote:
> Brian Norris <computersforpeace@gmail.com> writes:
>
> > I don't have very strong opinions on this. It's kind of annoying to have
> > this sort of stuff duplicated for every driver, if it's really needed.
> > But I'll admit this kind of infrastructure is sometimes useful.
> >
> > Anecdote: I recently found the regmap trace event infrastructure pretty
> > nice for debugging some other drivers. This would only require you to
> > have tracing enabled, and then no recompiles are necessary at all. Just
> > cmdline changes.
> >
> > So, I could go with this patch, if Robert still desires it. Or you could
> > convert to using regmap for MMIO :)
> I'm as you, I don't feel strong opinion about it, I'd like to have a debug
> tracing tool, be that this patch or regmap MMIO.
Regmap is probably overkill, and wouldn't do a lot to satisfy Ezequiel's
concern, I expect.
> If we all agree on a path I could even make the final patch, whichever solution
> is chosen.
I'm OK with this one, which still applies OK for me. But I do have one
comment, which I'll post at the top-level.
Brian
next prev parent reply other threads:[~2016-01-07 0:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 19:57 [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Robert Jarzmik
2015-08-11 19:57 ` [PATCH 2/3] mtd: nand: pxa3xx_nand: fix early spurious interrupt Robert Jarzmik
2015-08-11 19:57 ` [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik
2015-08-16 21:36 ` Ezequiel Garcia
2015-08-16 22:22 ` Robert Jarzmik
2015-08-17 17:31 ` Ezequiel Garcia
2015-08-17 19:03 ` Robert Jarzmik
2015-08-18 8:59 ` Antoine Tenart
2015-08-18 4:24 ` [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Ezequiel Garcia
2015-08-18 18:26 ` Robert Jarzmik
2015-08-23 19:09 ` Robert Jarzmik
2015-08-24 13:46 ` Ezequiel Garcia
2015-12-19 0:48 ` Brian Norris
2015-12-19 12:19 ` Robert Jarzmik
2016-01-07 0:04 ` Brian Norris [this message]
2016-01-07 0:06 ` Brian Norris
2016-01-10 20:34 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107000410.GR109450@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).