From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
"Franklin S Cooper Jr." <fcooper@ti.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] mtd: nand: return consistent error codes in ecc.correct() implementations
Date: Wed, 6 Jan 2016 18:48:12 -0800 [thread overview]
Message-ID: <20160107024812.GZ109450@google.com> (raw)
In-Reply-To: <1451503927-10831-2-git-send-email-boris.brezillon@free-electrons.com>
On Wed, Dec 30, 2015 at 08:32:03PM +0100, Boris Brezillon wrote:
> The error code returned by the ecc.correct() are not consistent over the
> all implementations.
>
> Document the expected behavior in include/linux/mtd/nand.h and fix
> offending implementations.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> drivers/mtd/nand/bf5xx_nand.c | 20 ++++++++++++++------
> drivers/mtd/nand/davinci_nand.c | 6 +++---
> drivers/mtd/nand/jz4740_nand.c | 4 ++--
> drivers/mtd/nand/mxc_nand.c | 4 ++--
> drivers/mtd/nand/nand_bch.c | 2 +-
> drivers/mtd/nand/nand_ecc.c | 2 +-
> drivers/mtd/nand/omap2.c | 6 +++---
> drivers/mtd/nand/r852.c | 4 ++--
> include/linux/mtd/nand.h | 8 +++++++-
> include/linux/mtd/nand_bch.h | 2 +-
> 11 files changed, 37 insertions(+), 23 deletions(-)
Pushed patch 1, with added commentary about the bf5xx_nand bugfix.
Brian
next prev parent reply other threads:[~2016-01-07 2:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 19:32 [PATCH v4 0/5] mtd: nand: properly handle bitflips in erased pages Boris Brezillon
2015-12-30 19:32 ` [PATCH v4 1/5] mtd: nand: return consistent error codes in ecc.correct() implementations Boris Brezillon
2016-01-07 2:48 ` Brian Norris [this message]
2015-12-30 19:32 ` [PATCH v4 2/5] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions Boris Brezillon
2016-01-07 2:50 ` Brian Norris
2015-12-30 19:32 ` [PATCH v4 3/5] mtd: nand: davinci: remove custom 'erased check' implementation Boris Brezillon
2016-01-07 2:55 ` Brian Norris
2015-12-30 19:32 ` [PATCH v4 4/5] mtd: nand: diskonchip: " Boris Brezillon
2015-12-30 19:39 ` [PATCH v5 " Boris Brezillon
2015-12-30 19:32 ` [PATCH v4 5/5] mtd: nand: jz4740: " Boris Brezillon
2015-12-30 19:41 ` [PATCH v5 " Boris Brezillon
2015-12-30 23:34 ` [PATCH v4 0/5] mtd: nand: properly handle bitflips in erased pages Franklin S Cooper Jr.
2016-01-07 3:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107024812.GZ109450@google.com \
--to=computersforpeace@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=fcooper@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).