* [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment
@ 2016-01-07 18:02 Brian Norris
2016-01-07 19:32 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-01-07 18:02 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Harvey Hunt, Boris Brezillon, Alex Smith
As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this
assignment isn't necessary, since struct mtd_info is embedded in struct
nand_chip.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Alex Smith <alex@alex-smith.me.uk>
---
drivers/mtd/nand/jz4780_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
index 17eb9f264187..6156c554e1c2 100644
--- a/drivers/mtd/nand/jz4780_nand.c
+++ b/drivers/mtd/nand/jz4780_nand.c
@@ -270,7 +270,6 @@ static int jz4780_nand_init_chip(struct platform_device *pdev,
chip = &nand->chip;
mtd = nand_to_mtd(chip);
- mtd->priv = chip;
mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev),
cs->bank);
if (!mtd->name)
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment
2016-01-07 18:02 [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment Brian Norris
@ 2016-01-07 19:32 ` Boris Brezillon
2016-01-07 20:27 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2016-01-07 19:32 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Harvey Hunt, Alex Smith
On Thu, 7 Jan 2016 10:02:59 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this
> assignment isn't necessary, since struct mtd_info is embedded in struct
> nand_chip.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Alex Smith <alex@alex-smith.me.uk>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/jz4780_nand.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index 17eb9f264187..6156c554e1c2 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -270,7 +270,6 @@ static int jz4780_nand_init_chip(struct platform_device *pdev,
>
> chip = &nand->chip;
> mtd = nand_to_mtd(chip);
> - mtd->priv = chip;
> mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev),
> cs->bank);
> if (!mtd->name)
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment
2016-01-07 19:32 ` Boris Brezillon
@ 2016-01-07 20:27 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-01-07 20:27 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linux-mtd, Harvey Hunt, Alex Smith
On Thu, Jan 07, 2016 at 08:32:47PM +0100, Boris Brezillon wrote:
> On Thu, 7 Jan 2016 10:02:59 -0800
> Brian Norris <computersforpeace@gmail.com> wrote:
>
> > As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this
> > assignment isn't necessary, since struct mtd_info is embedded in struct
> > nand_chip.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Cc: Alex Smith <alex@alex-smith.me.uk>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks! Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-07 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 18:02 [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment Brian Norris
2016-01-07 19:32 ` Boris Brezillon
2016-01-07 20:27 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).