From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
<linux-mtd@lists.infradead.org>,
Alex Smith <alex@alex-smith.me.uk>
Subject: Re: [PATCH] mtd: jz4780_nand: replace if/else blocks with switch/case
Date: Fri, 8 Jan 2016 13:41:31 +0100 [thread overview]
Message-ID: <20160108134131.7d85fea6@bbrezillon> (raw)
In-Reply-To: <568FABE8.8070604@imgtec.com>
On Fri, 8 Jan 2016 12:30:32 +0000
Harvey Hunt <harvey.hunt@imgtec.com> wrote:
> Hi,
>
> On 08/01/16 12:28, Boris Brezillon wrote:
> > On Thu, 7 Jan 2016 09:53:08 -0800
> > Brian Norris <computersforpeace@gmail.com> wrote:
> >
> >> Using switch/case helps make this logic more clear and more robust. With
> >> this structure:
> >>
> >> * it's clear that this driver only support ECC_{HW,SOFT,SOFT_BCH}; and
> >>
> >> * we can sanely handle new ECC unsupported modes (right now, this code
> >> makes incorrect assumptions about the possible values in the
> >> nand_ecc_modes_t enum; e.g., what happens with NAND_ECC_HW_OOB_FIRST?)
> >>
> >> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> >> Cc: Alex Smith <alex@alex-smith.me.uk>
> >> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> >
> > LGTM
> >
> > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
>
> If it helps, I can add my Tested-By later today?
Yes, that would be good, I only reviewed the changes, a real test would
confirm it does not break anything.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-08 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:53 [PATCH] mtd: jz4780_nand: replace if/else blocks with switch/case Brian Norris
2016-01-08 12:28 ` Boris Brezillon
2016-01-08 12:30 ` Harvey Hunt
2016-01-08 12:41 ` Boris Brezillon [this message]
2016-01-08 16:26 ` Harvey Hunt
2016-01-08 17:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108134131.7d85fea6@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alex@alex-smith.me.uk \
--cc=computersforpeace@gmail.com \
--cc=harvey.hunt@imgtec.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).