From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Daniel Walter <dwalter@sigma-star.at>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [RFC] [PATCH] mtd: add tracepoints for mtd_read and mtd_write
Date: Fri, 8 Jan 2016 09:57:41 -0800 [thread overview]
Message-ID: <20160108175741.GO109450@google.com> (raw)
In-Reply-To: <CAFLxGvxPHN0JcEZShS_QV869U_E+Rdk=DYTCTeUHQ-eiH4_BfA@mail.gmail.com>
On Fri, Jan 08, 2016 at 10:33:03AM +0100, Richard Weinberger wrote:
> On Tue, Nov 17, 2015 at 8:18 PM, Daniel Walter <dwalter@sigma-star.at> wrote:
> > Add tracepoints to mtd subsystem for read and write
> > operations. This should allow us to identify applications
> > which are generating too much reads/writes on a flash-device.
> >
> > Signed-off-by: Daniel Walter <dwalter@sigma-star.at>
>
> Brian, any comments on this?
Only a few. I'm not very familiar with writing trace events. I've only
barely used them! And I haven't run this patch yet.
But I thought Daniel reported having some difficulty here -- that it
isn't actually that useful to get real "user" information, since most
writing/erasing happens from background UBI tasks in practice. So is
this still the best mechanism for tracking this information? (Even if
there's better ways to get info directly out of UBI, I guess maybe it'd
still be good to have this infrastructure.)
Also, maybe I'm missing something, but it doesn't look like this
attempts to record *which* MTD is being accessed, right? I'd think
logging mtd->name could help?
Brian
next prev parent reply other threads:[~2016-01-08 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 19:14 [RFC] Trace-events for mtd Daniel Walter
2015-11-17 19:18 ` [RFC] [PATCH] mtd: add tracepoints for mtd_read and mtd_write Daniel Walter
2016-01-08 9:33 ` Richard Weinberger
2016-01-08 17:57 ` Brian Norris [this message]
2016-01-14 1:12 ` Daniel Walter
2016-01-08 18:00 ` [RFC] Trace-events for mtd Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108175741.GO109450@google.com \
--to=computersforpeace@gmail.com \
--cc=dwalter@sigma-star.at \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).