[PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt()

[PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt()

[Thomas Petazzoni]

Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt:
make nand_scan_bbt() static"), the nand_scan_bbt() function is marked
as static but is still exported using EXPORT_SYMBOL(), which doesn't
make much sense.

This commit gets rid of the useless EXPORT_SYMBOL.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/mtd/nand/nand_bbt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index b1d4f81..4dfaf93 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -1373,5 +1373,3 @@ int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs)
 
 	return ret;
 }
-
-EXPORT_SYMBOL(nand_scan_bbt);
-- 
2.6.4

[PATCH 2/3] mtd: onenand: make onenand_scan_bbt() static

[Thomas Petazzoni]

Like was done in commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf
("mtd: nand_bbt: make nand_scan_bbt() static") for the NAND code, this
commit makes the onenand_scan_bbt() function static in the OneNAND
code, since it is only used in onenand_bbt.c itself.

Consequently, the EXPORT_SYMBOL() and declaration in bbm.h are also
removed.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/mtd/onenand/onenand_bbt.c | 3 +--
 include/linux/mtd/bbm.h           | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
index 08d0085..5f8d470 100644
--- a/drivers/mtd/onenand/onenand_bbt.c
+++ b/drivers/mtd/onenand/onenand_bbt.c
@@ -179,7 +179,7 @@ static int onenand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt)
  * by the onenand_release function.
  *
  */
-int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
+static int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
 {
 	struct onenand_chip *this = mtd->priv;
 	struct bbm_info *bbm = this->bbm;
@@ -248,5 +248,4 @@ int onenand_default_bbt(struct mtd_info *mtd)
 	return onenand_scan_bbt(mtd, bbm->badblock_pattern);
 }
 
-EXPORT_SYMBOL(onenand_scan_bbt);
 EXPORT_SYMBOL(onenand_default_bbt);
diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index 36bb6a5..3bf8f95 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
@@ -166,7 +166,6 @@ struct bbm_info {
 };
 
 /* OneNAND BBT interface */
-extern int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd);
 extern int onenand_default_bbt(struct mtd_info *mtd);
 
 #endif	/* __LINUX_MTD_BBM_H */
-- 
2.6.4

Re: [PATCH 2/3] mtd: onenand: make onenand_scan_bbt() static

[Boris Brezillon]

+Peter

On Thu, 14 Jan 2016 15:44:50 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Like was done in commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf
> ("mtd: nand_bbt: make nand_scan_bbt() static") for the NAND code, this
> commit makes the onenand_scan_bbt() function static in the OneNAND
> code, since it is only used in onenand_bbt.c itself.
> 
> Consequently, the EXPORT_SYMBOL() and declaration in bbm.h are also
> removed.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Not sure how this will impact the BBT rework done by Peter, but those
are trivial changes, so I guess it should be pretty easy to fix the
conflicts in case Brian decides to take them before the BBT rework
changes.

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/mtd/onenand/onenand_bbt.c | 3 +--
>  include/linux/mtd/bbm.h           | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
> index 08d0085..5f8d470 100644
> --- a/drivers/mtd/onenand/onenand_bbt.c
> +++ b/drivers/mtd/onenand/onenand_bbt.c
> @@ -179,7 +179,7 @@ static int onenand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt)
>   * by the onenand_release function.
>   *
>   */
> -int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
> +static int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
>  {
>  	struct onenand_chip *this = mtd->priv;
>  	struct bbm_info *bbm = this->bbm;
> @@ -248,5 +248,4 @@ int onenand_default_bbt(struct mtd_info *mtd)
>  	return onenand_scan_bbt(mtd, bbm->badblock_pattern);
>  }
>  
> -EXPORT_SYMBOL(onenand_scan_bbt);
>  EXPORT_SYMBOL(onenand_default_bbt);
> diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
> index 36bb6a5..3bf8f95 100644
> --- a/include/linux/mtd/bbm.h
> +++ b/include/linux/mtd/bbm.h
> @@ -166,7 +166,6 @@ struct bbm_info {
>  };
>  
>  /* OneNAND BBT interface */
> -extern int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd);
>  extern int onenand_default_bbt(struct mtd_info *mtd);
>  
>  #endif	/* __LINUX_MTD_BBM_H */



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH 3/3] mtd: onenand: unexport onenand_default_bbt()

[Thomas Petazzoni]

The onenand_default_bbt() function is only used by the OneNAND core
and not by drivers, so there is no real need to export
it. Additionally, the corresponding nand_default_bbt() for regular
NANDs is not exported either, so for consistency reasons, this commit
removes the EXPORT_SYMBOL on onenand_default_bbt().

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/mtd/onenand/onenand_bbt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
index 5f8d470..680188a 100644
--- a/drivers/mtd/onenand/onenand_bbt.c
+++ b/drivers/mtd/onenand/onenand_bbt.c
@@ -247,5 +247,3 @@ int onenand_default_bbt(struct mtd_info *mtd)
 
 	return onenand_scan_bbt(mtd, bbm->badblock_pattern);
 }
-
-EXPORT_SYMBOL(onenand_default_bbt);
-- 
2.6.4

Re: [PATCH 3/3] mtd: onenand: unexport onenand_default_bbt()

[Boris Brezillon]

On Thu, 14 Jan 2016 15:44:51 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> The onenand_default_bbt() function is only used by the OneNAND core
> and not by drivers, so there is no real need to export
> it. Additionally, the corresponding nand_default_bbt() for regular
> NANDs is not exported either, so for consistency reasons, this commit
> removes the EXPORT_SYMBOL on onenand_default_bbt().
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/mtd/onenand/onenand_bbt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
> index 5f8d470..680188a 100644
> --- a/drivers/mtd/onenand/onenand_bbt.c
> +++ b/drivers/mtd/onenand/onenand_bbt.c
> @@ -247,5 +247,3 @@ int onenand_default_bbt(struct mtd_info *mtd)
>  
>  	return onenand_scan_bbt(mtd, bbm->badblock_pattern);
>  }
> -
> -EXPORT_SYMBOL(onenand_default_bbt);



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt()

[Boris Brezillon]

Hi Thomas,

On Thu, 14 Jan 2016 15:44:49 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt:
> make nand_scan_bbt() static"), the nand_scan_bbt() function is marked
> as static but is still exported using EXPORT_SYMBOL(), which doesn't
> make much sense.
> 
> This commit gets rid of the useless EXPORT_SYMBOL.

Hehe, I noticed this useless EXPORT_SYMBOL while reviewing the BBT
rework, just forgot to post the patch removing it.

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  drivers/mtd/nand/nand_bbt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
> index b1d4f81..4dfaf93 100644
> --- a/drivers/mtd/nand/nand_bbt.c
> +++ b/drivers/mtd/nand/nand_bbt.c
> @@ -1373,5 +1373,3 @@ int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs)
>  
>  	return ret;
>  }
> -
> -EXPORT_SYMBOL(nand_scan_bbt);



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt()

[Brian Norris]

On Thu, Jan 14, 2016 at 03:44:49PM +0100, Thomas Petazzoni wrote:
> Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt:
> make nand_scan_bbt() static"), the nand_scan_bbt() function is marked
> as static but is still exported using EXPORT_SYMBOL(), which doesn't
> make much sense.
> 
> This commit gets rid of the useless EXPORT_SYMBOL.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Pushed all 3 to l2-mtd.git/next