From: Brian Norris <computersforpeace@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH] mtd: brcmnand: set initial ECC params based on info from HW
Date: Mon, 1 Feb 2016 12:49:26 -0800 [thread overview]
Message-ID: <20160201204926.GL19540@google.com> (raw)
In-Reply-To: <56AFC102.5090000@gmail.com>
On Mon, Feb 01, 2016 at 12:33:06PM -0800, Florian Fainelli wrote:
> On 01/02/16 11:02, Brian Norris wrote:
> > On Mon, Feb 01, 2016 at 10:09:28AM -0800, Florian Fainelli wrote:
> >> The Marvell PXA3XX NAND controller has a "marvell,nand-keep-config"
> >> which seems to be in par with what Rafal is after here, maybe it would
> >> be worth standardizing/mimicing that kind of property for the brcmnand
> >> driver?
> >
> > Maybe. Honestly, it's not that clear to me what the pxa3xx-nand binding
> > means. But if we make that clear, that could be a possibility.
>
> I would argue that if you were down the road of looking at the
> bootloader defaults to figure out why things did not work, it's not that
> much of a stretch to put the correct information in Device Tree, leading
> to predictable results, so ...
I wasn't suggesting trying to reintroduce any complex
bootloader-matching logic. I think either we should stick with:
(a) all info (ECC step size + strength) goes in DT (as-is) or
(b) we provide a DT option to say "keep the ECC settings configured by
the bootloader"
If we go with (a), I'd still propose my original suggestion, if that
helps Rafal's use case:
> >>> What if we just print out the hardware defaults when we bail out due to
> >>> missing ECC DT properties? Then developers can choose to set up their DT
> >>> with these properties, if those are actually proven correct. Would that
> >>> save you the hours of setup you mention?
Regards,
Brian
prev parent reply other threads:[~2016-02-01 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 7:58 [PATCH] mtd: brcmnand: set initial ECC params based on info from HW Rafał Miłecki
2016-02-01 17:53 ` Brian Norris
2016-02-01 18:09 ` Florian Fainelli
2016-02-01 19:02 ` Brian Norris
2016-02-01 20:33 ` Florian Fainelli
2016-02-01 20:49 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201204926.GL19540@google.com \
--to=computersforpeace@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=boris.brezillon@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).