From: Brian Norris <computersforpeace@gmail.com>
To: Romain Izard <romain.izard.pro@gmail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
Josh Wu <rainyfeeling@outlook.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Yang Wenyou <Wenyou.Yang@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v4 4/5] mtd: atmel_nand: Support 32-bit ECC strength
Date: Fri, 12 Feb 2016 10:30:15 -0800 [thread overview]
Message-ID: <20160212183015.GP19540@google.com> (raw)
In-Reply-To: <1455098187-9442-5-git-send-email-romain.izard.pro@gmail.com>
On Wed, Feb 10, 2016 at 10:56:26AM +0100, Romain Izard wrote:
> Documentation/devicetree/bindings/mtd/atmel-nand.txt | 3 ++-
> drivers/mtd/nand/atmel_nand.c | 19 +++++++++++++++++--
> drivers/mtd/nand/atmel_nand_ecc.h | 1 +
> 3 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> index e1887b7d7e53..d53aba98fbc9 100644
> --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> @@ -27,7 +27,8 @@ Optional properties:
> - atmel,has-pmecc : boolean to enable Programmable Multibit ECC hardware,
> capable of BCH encoding and decoding, on devices where it is present.
> - atmel,pmecc-cap : error correct capability for Programmable Multibit ECC
> - Controller. Supported values are: 2, 4, 8, 12, 24.
> + Controller. Supported values are: 2, 4, 8, 12, 24. If the compatible string
Looks like you could be using the common 'nand-ecc-strength' binding
here.
> + is "atmel,sama5d2-nand", 32 is also valid.
> - atmel,pmecc-sector-size : sector size for ECC computation. Supported values
> are: 512, 1024.
And 'nand-ecc-step-size' here.
> - atmel,pmecc-lookup-table-offset : includes two offsets of lookup table in ROM
Of course we can't break backward compatibility, but it'd be nice if you
made sure this worked with the generic bindings.
Regards,
Brian
next prev parent reply other threads:[~2016-02-12 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:56 [PATCH v4 0/5] mtd: atmel_nand: Add support for NAND Flash on SAMA5D2 Romain Izard
2016-02-10 9:56 ` [PATCH v4 1/5] mtd: atmel_nand: Support variable RB_EDGE interrupts Romain Izard
2016-02-12 18:27 ` Brian Norris
2016-02-10 9:56 ` [PATCH v4 2/5] dt-bindings: atmel_nand: Reword the documentation Romain Izard
2016-02-10 9:56 ` [PATCH v4 3/5] mtd: atmel_nand: Support PMECC on SAMA5D2 Romain Izard
2016-02-10 9:56 ` [PATCH v4 4/5] mtd: atmel_nand: Support 32-bit ECC strength Romain Izard
2016-02-12 18:30 ` Brian Norris [this message]
2016-02-10 9:56 ` [PATCH v4 5/5] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes Romain Izard
2016-03-01 12:28 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212183015.GP19540@google.com \
--to=computersforpeace@gmail.com \
--cc=Wenyou.Yang@atmel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=rainyfeeling@outlook.com \
--cc=robh@kernel.org \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).