From: Brian Norris <computersforpeace@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: onenand: fix deadlock in onenand_block_markbad
Date: Wed, 24 Feb 2016 10:19:57 -0800 [thread overview]
Message-ID: <20160224181957.GI21465@google.com> (raw)
In-Reply-To: <1456000068-8862-1-git-send-email-aaro.koskinen@iki.fi>
On Sat, Feb 20, 2016 at 10:27:48PM +0200, Aaro Koskinen wrote:
> Commit 5942ddbc500d ("mtd: introduce mtd_block_markbad interface")
> incorrectly changed onenand_block_markbad() to call mtd_block_markbad
> instead of onenand_chip's block_markbad function. As a result the function
> will now recurse and deadlock. Fix by reverting the change.
>
> Fixes: 5942ddbc500d ("mtd: introduce mtd_block_markbad interface")
Good to know onenand has been getting tested sometime in the last 5
year! /s
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>
> v2: Don't ignore the return value.
>
> v1: http://lists.infradead.org/pipermail/linux-mtd/2016-February/065582.html
Marked for -stable and pushed to l2-mtd.git.
Thanks,
Brian
prev parent reply other threads:[~2016-02-24 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 20:27 [PATCH v2] mtd: onenand: fix deadlock in onenand_block_markbad Aaro Koskinen
2016-02-24 11:59 ` Artem Bityutskiy
2016-02-24 18:19 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224181957.GI21465@google.com \
--to=computersforpeace@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).