From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: fcooper@ti.com, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, daniel.thompson@linaro.org,
xiaolei.li@mediatek.com
Subject: Re: [PATCH] mtd: nand: tests: fix regression introduced in mtd_nandectest
Date: Tue, 1 Mar 2016 22:17:55 +0100 [thread overview]
Message-ID: <20160301221755.093f5223@bbrezillon> (raw)
In-Reply-To: <1456866240-26119-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
Hi Jorge,
On Tue, 1 Mar 2016 16:04:00 -0500
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
> Offending Commit: 6e94119 "mtd: nand: return consistent error codes in
> ecc.correct() implementations"
>
> The new error code was not being handled properly in double bit error
> detection.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks,
Boris
> ---
> drivers/mtd/tests/mtd_nandecctest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/tests/mtd_nandecctest.c b/drivers/mtd/tests/mtd_nandecctest.c
> index 7931615..88b6c81 100644
> --- a/drivers/mtd/tests/mtd_nandecctest.c
> +++ b/drivers/mtd/tests/mtd_nandecctest.c
> @@ -187,7 +187,7 @@ static int double_bit_error_detect(void *error_data, void *error_ecc,
> __nand_calculate_ecc(error_data, size, calc_ecc);
> ret = __nand_correct_data(error_data, error_ecc, calc_ecc, size);
>
> - return (ret == -1) ? 0 : -EINVAL;
> + return (ret == -EBADMSG) ? 0 : -EINVAL;
> }
>
> static const struct nand_ecc_test nand_ecc_test[] = {
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-01 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 21:04 [PATCH] mtd: nand: tests: fix regression introduced in mtd_nandectest Jorge Ramirez-Ortiz
2016-03-01 21:17 ` Boris Brezillon [this message]
2016-03-02 15:50 ` Franklin S Cooper Jr.
2016-03-05 1:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301221755.093f5223@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=fcooper@ti.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox