From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ad02U-0006pv-D2 for linux-mtd@lists.infradead.org; Mon, 07 Mar 2016 18:37:55 +0000 Received: by mail-pa0-x243.google.com with SMTP id hj7so8174808pac.1 for ; Mon, 07 Mar 2016 10:37:33 -0800 (PST) Date: Mon, 7 Mar 2016 10:37:30 -0800 From: Brian Norris To: Robert Jarzmik Cc: linux-mtd@lists.infradead.org, Ezequiel Garcia Subject: [PATCH v2] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd' Message-ID: <20160307183730.GU55664@google.com> References: <1457147553-71596-1-git-send-email-computersforpeace@gmail.com> <877fhhwcft.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877fhhwcft.fsf@belgarion.home> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , With this removal, we don't need to 'get' the second DMA resource either, as it's also unused. Signed-off-by: Brian Norris --- On Sat, Mar 05, 2016 at 09:34:14AM +0100, Robert Jarzmik wrote: > Brian Norris writes: > > @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev) > > ret = -ENXIO; > > goto fail_disable_clk; > > } > > - info->drcmr_cmd = r->start; > > } > If you kill this field, why not kill also this block just above ? > r = platform_get_resource(pdev, IORESOURCE_DMA, 1); > if (r == NULL) { > dev_err(&pdev->dev, > "no resource defined for cmd DMA\n"); > ret = -ENXIO; > goto fail_disable_clk; > } Indeed, why not. drivers/mtd/nand/pxa3xx_nand.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index f100c4da0423..d6508856da99 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -211,7 +211,6 @@ struct pxa3xx_nand_info { struct dma_chan *dma_chan; dma_cookie_t dma_cookie; int drcmr_dat; - int drcmr_cmd; unsigned char *data_buff; unsigned char *oob_buff; @@ -1804,15 +1803,6 @@ static int alloc_nand_resource(struct platform_device *pdev) goto fail_disable_clk; } info->drcmr_dat = r->start; - - r = platform_get_resource(pdev, IORESOURCE_DMA, 1); - if (r == NULL) { - dev_err(&pdev->dev, - "no resource defined for cmd DMA\n"); - ret = -ENXIO; - goto fail_disable_clk; - } - info->drcmr_cmd = r->start; } irq = platform_get_irq(pdev, 0); -- 2.7.0.rc3.207.g0ac5344