From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aigH8-0004k6-GB for linux-mtd@lists.infradead.org; Wed, 23 Mar 2016 10:44:31 +0000 Date: Wed, 23 Mar 2016 11:43:57 +0100 From: Boris Brezillon To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Brian Norris , linux-mtd@lists.infradead.org, Kamal Dasu , Rob Herring , Frank Rowand , Grant Likely , devicetree@vger.kernel.org Subject: Re: [PATCH V2 0/4] mtd: nand: add enum nand_ecc_algo Message-ID: <20160323114357.377d82fc@bbrezillon> In-Reply-To: <1458728343-1234-1-git-send-email-zajec5@gmail.com> References: <1458728343-1234-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 23 Mar 2016 11:18:59 +0100 Rafa=C5=82 Mi=C5=82ecki wrote: > Some time ago I started working on a new "nand-ecc-algo" property to allow > specifying ECC algorithm for hardware ECC mode as well. > Boris pointed out it's becoming a bit messy that way as we already have v= alue > NAND_ECC_SOFT_BCH. > I suggested deprecating "soft_bch" value from nand-ecc-mode property and = got > Boris agreed and no objections from others. So there is how I want to imp= lement > this. > If you agree on this way & apply my patches, I'll start modifying NAND dr= ivers > (similarly to the nandsim) and then will try to drop NAND_ECC_SOFT_BCH ex= cept > for handling backward compatibility. > Then finally we should be able to add "nand-ecc-algo" property support pr= operly. >=20 > V2: Add of_get_nand_ecc_algo helper (in 2/4) instead of this slightly hac= ky code > in nand_dt_init that would be replaced anyway. This version looks good to me. If nobody disagree, I'll apply those patches on my future nand/next branch. Thanks, Boris >=20 > Rafa=C5=82 Mi=C5=82ecki (4): > mtd: nand: add new enum for storing ECC algorithm > of: mtd: prepare helper reading NAND ECC algo from DT > mtd: nand: set ECC algorithm in nand_dt_init > mtd: nand: nandsim: set ECC algorithm explicitly >=20 > drivers/mtd/nand/nand_base.c | 6 +++++- > drivers/mtd/nand/nandsim.c | 2 ++ > drivers/of/of_mtd.c | 36 ++++++++++++++++++++++++++++++++++++ > include/linux/mtd/nand.h | 7 +++++++ > include/linux/of_mtd.h | 6 ++++++ > 5 files changed, 56 insertions(+), 1 deletion(-) >=20 --=20 Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com