From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: alex@alex-smith.me.uk, harvey.hunt@imgtec.com,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
Date: Wed, 30 Mar 2016 16:34:32 +0200 [thread overview]
Message-ID: <20160330163432.29c3864c@bbrezillon> (raw)
In-Reply-To: <1458784407-12908-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
On Wed, 23 Mar 2016 21:53:27 -0400
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
How about adding the following message:
"
bch->dev is already assigned to &pdev->dev in the probe function.
Remove the duplicate assignment done in jz4780_bch_get().
"
If you agree I'll add this commit message while applying (no need to
resend).
Harvey, can I have your ack on this patch?
Thanks,
Boris
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/mtd/nand/jz4780_bch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
> index 755499c..d74f4ba 100644
> --- a/drivers/mtd/nand/jz4780_bch.c
> +++ b/drivers/mtd/nand/jz4780_bch.c
> @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
> bch = platform_get_drvdata(pdev);
> clk_prepare_enable(bch->clk);
>
> - bch->dev = &pdev->dev;
> return bch;
> }
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-30 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 1:53 [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe Jorge Ramirez-Ortiz
2016-03-24 14:54 ` Ezequiel Garcia
2016-03-30 14:34 ` Boris Brezillon [this message]
2016-03-30 14:36 ` Harvey Hunt
2016-03-30 15:01 ` Boris Brezillon
2016-03-30 14:37 ` Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330163432.29c3864c@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alex@alex-smith.me.uk \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=harvey.hunt@imgtec.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox