From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1alHCw-0000UX-Kv for linux-mtd@lists.infradead.org; Wed, 30 Mar 2016 14:34:55 +0000 Date: Wed, 30 Mar 2016 16:34:32 +0200 From: Boris Brezillon To: Jorge Ramirez-Ortiz Cc: alex@alex-smith.me.uk, harvey.hunt@imgtec.com, linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, Ezequiel Garcia Subject: Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe Message-ID: <20160330163432.29c3864c@bbrezillon> In-Reply-To: <1458784407-12908-1-git-send-email-jorge.ramirez-ortiz@linaro.org> References: <1458784407-12908-1-git-send-email-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 23 Mar 2016 21:53:27 -0400 Jorge Ramirez-Ortiz wrote: How about adding the following message: " bch->dev is already assigned to &pdev->dev in the probe function. Remove the duplicate assignment done in jz4780_bch_get(). " If you agree I'll add this commit message while applying (no need to resend). Harvey, can I have your ack on this patch? Thanks, Boris > Signed-off-by: Jorge Ramirez-Ortiz > --- > drivers/mtd/nand/jz4780_bch.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c > index 755499c..d74f4ba 100644 > --- a/drivers/mtd/nand/jz4780_bch.c > +++ b/drivers/mtd/nand/jz4780_bch.c > @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np) > bch = platform_get_drvdata(pdev); > clk_prepare_enable(bch->clk); > > - bch->dev = &pdev->dev; > return bch; > } > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com