From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 0/2] nand: Remove BUG abuse
Date: Sat, 2 Apr 2016 15:55:56 +0200 [thread overview]
Message-ID: <20160402155556.41cde687@bbrezillon> (raw)
In-Reply-To: <1459546164-6269-1-git-send-email-ezequiel@vanguardiasur.com.ar>
Hi Ezequiel,
On Fri, 1 Apr 2016 18:29:22 -0300
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
> Hi,
>
> While using nandsim to debug an issue with an UBI image,
> I hit a BUG() when passing some crazy ID values to nandsim.
>
> I've always felt that nand_base.c is sort of abusing the
> BUG() macro, so decided to fix it.
>
> There are other BUG() uses, but they aren't in the nand_scan
> path, so I'm not touching them.
Now that you've opened the door to this rework, can you also patch other
locations where BUG() is employed? :)
Thanks,
Boris
>
> Patches apply cleanly on v4.6-rc1.
>
> Ezequiel Garcia (2):
> mtd: nand: Drop mtd.owner requirement in nand_scan
> mtd: nand: Remove BUG() abuse in nand_scan_tail
>
> drivers/mtd/nand/nand_base.c | 62 ++++++++++++++++++++++++--------------------
> 1 file changed, 34 insertions(+), 28 deletions(-)
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-02 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 21:29 [PATCH 0/2] nand: Remove BUG abuse Ezequiel Garcia
2016-04-01 21:29 ` [PATCH 1/2] mtd: nand: Drop mtd.owner requirement in nand_scan Ezequiel Garcia
2016-04-01 21:57 ` Richard Weinberger
2016-04-01 22:06 ` Ezequiel Garcia
2016-04-01 22:26 ` Brian Norris
2016-04-02 13:52 ` Boris Brezillon
2016-04-03 6:14 ` Brian Norris
2016-04-01 21:29 ` [PATCH 2/2] mtd: nand: Remove BUG() abuse in nand_scan_tail Ezequiel Garcia
2016-04-01 21:51 ` Richard Weinberger
2016-04-02 13:55 ` Boris Brezillon
2016-04-04 15:20 ` Boris Brezillon
2016-04-04 15:26 ` Ezequiel Garcia
2016-04-04 15:30 ` Richard Weinberger
2016-04-04 15:34 ` Ezequiel Garcia
2016-04-04 18:30 ` Boris Brezillon
2016-04-04 16:43 ` Brian Norris
2016-04-05 16:58 ` Boris Brezillon
2016-04-02 13:55 ` Boris Brezillon [this message]
2016-04-02 15:37 ` [PATCH 0/2] nand: Remove BUG abuse Ezequiel Garcia
2016-04-04 15:33 ` Boris Brezillon
2016-04-04 15:39 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160402155556.41cde687@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox