From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM STB
NAND FLASH DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 3/3] mtd: brcmnand: respect ECC algorithm set by NAND subsystem
Date: Mon, 25 Apr 2016 17:05:10 +0200 [thread overview]
Message-ID: <20160425170510.26a3eb63@bbrezillon> (raw)
In-Reply-To: <1461324197-1333-3-git-send-email-zajec5@gmail.com>
On Fri, 22 Apr 2016 13:23:15 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> It's more reliable than guessing based on ECC strength. It allows using
> NAND on devices with BCH-1 (e.g. D-Link DIR-885L).
Brian, Kamal, could you add your Ack on this patch.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index c3331ff..dcb22dc 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -1927,7 +1927,7 @@ static int brcmnand_setup_dev(struct brcmnand_host *host)
>
> switch (chip->ecc.size) {
> case 512:
> - if (chip->ecc.strength == 1) /* Hamming */
> + if (chip->ecc.algo == NAND_ECC_HAMMING)
> cfg->ecc_level = 15;
> else
> cfg->ecc_level = chip->ecc.strength;
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-25 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 11:23 [PATCH 1/3] mtd: nand: add support for "nand-ecc-algo" DT property Rafał Miłecki
2016-04-22 11:23 ` [PATCH 2/3] Documentation: devicetree: deprecate "soft_bch" nand-ecc-mode value Rafał Miłecki
2016-04-25 12:40 ` Rob Herring
2016-04-26 7:34 ` Boris Brezillon
2016-04-22 11:23 ` [PATCH 3/3] mtd: brcmnand: respect ECC algorithm set by NAND subsystem Rafał Miłecki
2016-04-25 15:05 ` Boris Brezillon [this message]
2016-04-26 5:53 ` Brian Norris
2016-04-26 7:37 ` Boris Brezillon
2016-04-26 18:38 ` Rafał Miłecki
2016-04-27 7:55 ` Boris Brezillon
2016-04-25 10:11 ` [PATCH 1/3] mtd: nand: add support for "nand-ecc-algo" DT property Boris Brezillon
2016-04-25 12:39 ` Rob Herring
2016-04-26 7:34 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425170510.26a3eb63@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).