public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	Daniel Walter <dwalter@sigma-star.at>
Subject: Re: Pass -EUCLEAN to userspace?
Date: Tue, 26 Apr 2016 09:13:27 +0200	[thread overview]
Message-ID: <20160426071327.GJ7860@pengutronix.de> (raw)
In-Reply-To: <20160425161144.0f366c9e@bbrezillon>

Fixed typo in subject, maybe this helps finding this thread in the
archives.

On Mon, Apr 25, 2016 at 04:11:44PM +0200, Boris Brezillon wrote:
> On Mon, 25 Apr 2016 11:26:16 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
> > > > 
> > > > Regarding the maximum number of bitflips per chunk, maybe we can make it
> > > > part of the ioctl request instead of saving the statistics at the MTD
> > > > level.
> > > > 
> > > > How about creating a new ioctl taking a pointer to this struct as a
> > > > parameter:
> > > > 
> > > > struct mtd_extended_read_ops {
> > > > 	/* Existing params */
> > > > 	unsigned int mode;
> > > > 	size_t len;
> > > > 	size_t retlen;
> > > > 	size_t ooblen;
> > > > 	size_t oobretlen;
> > > > 	uint32_t ooboffs;
> > > > 	void *datbuf;
> > > > 	void *oobbuf;
> > > > 
> > > > 	/*
> > > > 	 * Param containing the maximum number of bitflips for this
> > > > 	 * read request.
> > > > 	 */
> > > > 	unsigned int max_bitflips;
> > > > };    
> > > 
> > > Not sure how this ioctl exactly should look like, but this would solve
> > > the problem.  
> > 
> > Let me design a quick prototype, I'll let you follow up with the patch
> > submission process...
> 
> Below is an untested patch adding a new ioctl returning the ECC/read stats.
> Feel free to debug/enhance this implementation and submit it to the MTD
> ML.

Thanks Boris, I'll give it a try.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2016-04-26  7:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 13:25 Pass -EUCLEN to userspace? Sascha Hauer
2016-04-22 15:24 ` Boris Brezillon
2016-04-22 15:28   ` Boris Brezillon
2016-04-22 15:48     ` Richard Weinberger
2016-04-22 16:11       ` Boris Brezillon
2016-04-22 18:20         ` Richard Weinberger
2016-04-22 18:39           ` Boris Brezillon
2016-04-25  5:28       ` Sascha Hauer
2016-04-25  7:50         ` Boris Brezillon
2016-04-25  8:22           ` Sascha Hauer
2016-04-25  8:40             ` Boris Brezillon
2016-04-25  9:14               ` Sascha Hauer
2016-04-25  9:26                 ` Boris Brezillon
2016-04-25 14:11                   ` Boris Brezillon
2016-04-26  7:13                     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426071327.GJ7860@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=boris.brezillon@free-electrons.com \
    --cc=dwalter@sigma-star.at \
    --cc=kernel@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox