From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1avKj4-000661-Fs for linux-mtd@lists.infradead.org; Wed, 27 Apr 2016 08:21:39 +0000 Date: Wed, 27 Apr 2016 10:21:01 +0200 From: Boris Brezillon To: Richard Weinberger Cc: linux-mtd@lists.infradead.org Subject: Re: [PATCH] flash_eraseall: Remove warning Message-ID: <20160427102101.13c6d017@bbrezillon> In-Reply-To: <1461701022-21023-1-git-send-email-richard@nod.at> References: <1461701022-21023-1-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 26 Apr 2016 22:03:42 +0200 Richard Weinberger wrote: > Well, flash_erase 0 0 is the same as flash_eraseall . > But flash_eraseall is still more handy to use. > Let's keep flash_eraseall as short cut and don't force users to > use a less handy user interface. Hm, I'm not convinced by this change. Aren't we trying to make people switch to flash_erase instead of using flash_eraseall. If you want to make flash_erase more easy to use, you can always erase the whole partition if only is passed in arguments, which IMO would be clearer than having to pass 0 0. > > Signed-off-by: Richard Weinberger > --- > misc-utils/flash_eraseall | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/misc-utils/flash_eraseall b/misc-utils/flash_eraseall > index c5539b3..65a85cc 100755 > --- a/misc-utils/flash_eraseall > +++ b/misc-utils/flash_eraseall > @@ -1,4 +1,3 @@ > #!/bin/sh > -echo "${0##*/} has been replaced by \`flash_erase 0 0\`; please use it" 1>&2 > [ $# -ne 0 ] && set -- "$@" 0 0 > exec flash_erase "$@" -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com