From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1avKrS-0000C0-RK for linux-mtd@lists.infradead.org; Wed, 27 Apr 2016 08:30:20 +0000 Date: Wed, 27 Apr 2016 10:29:47 +0200 From: Boris Brezillon To: Richard Weinberger Cc: linux-mtd@lists.infradead.org Subject: Re: [PATCH] flash_eraseall: Remove warning Message-ID: <20160427102947.634d5ece@bbrezillon> In-Reply-To: <572077F5.9080004@nod.at> References: <1461701022-21023-1-git-send-email-richard@nod.at> <20160427102101.13c6d017@bbrezillon> <572077F5.9080004@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 27 Apr 2016 10:27:33 +0200 Richard Weinberger wrote: > Am 27.04.2016 um 10:21 schrieb Boris Brezillon: > >> Well, flash_erase 0 0 is the same as flash_eraseall . > >> But flash_eraseall is still more handy to use. > >> Let's keep flash_eraseall as short cut and don't force users to > >> use a less handy user interface. > > > > Hm, I'm not convinced by this change. Aren't we trying to make people > > switch to flash_erase instead of using flash_eraseall. > > If you want to make flash_erase more easy to use, you can always erase > > the whole partition if only is passed in arguments, which IMO > > would be clearer than having to pass 0 0. > > So, you suggest fixing flash_erase such that a "flash_erase /dev/mtd0" > works and acts like "flash_erase /dev/mtd0 0 0"? Yep. > > Would work too. :-) > > Thanks, > //richard -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com