From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/8] mtd-utils: Add multi-block erase function
Date: Wed, 27 Apr 2016 11:27:27 +0200 [thread overview]
Message-ID: <20160427112727.0d767fac@bbrezillon> (raw)
In-Reply-To: <e3758952-76e9-8b62-f575-42248f2d66f4@sigma-star.at>
Hi David,
On Wed, 27 Apr 2016 11:21:31 +0200
David Oberhollenzer <david.oberhollenzer@sigma-star.at> wrote:
> On 04/26/2016 10:04 AM, Boris Brezillon wrote:
> >> -int mtd_erase(libmtd_t desc, const struct mtd_dev_info *mtd, int fd, int eb)
> >> +int mtd_erase_multi(libmtd_t desc, const struct mtd_dev_info *mtd,
> >> + int fd, int eb, int blocks)
> >> {
> >> int ret;
> >> struct libmtd *lib = (struct libmtd *)desc;
> >> @@ -856,8 +857,12 @@ int mtd_erase(libmtd_t desc, const struct mtd_dev_info *mtd, int fd, int eb)
> >> if (ret)
> >> return ret;
> >>
> >> - ei64.start = (__u64)eb * mtd->eb_size;
> >> - ei64.length = mtd->eb_size;
> >> + ret = mtd_valid_erase_block(mtd, eb + blocks - 1);
> >> + if (ret)
> >> + return ret;
> >
> > Maybe you should also check if @eb is a valid block (what if @eb < 0,
> > but @eb + @blocks >= 0).
> >
> This patch only renames the mtd_erase function to mtd_erase_multi and lets it
> accept a block count. The existing code already checks @eb for validity.
My bad, just didn't look at the original file before commenting.
Thanks for the clarification.
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-27 9:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 22:13 [RFC] Porting kernel MTD tests to user space Richard Weinberger
2016-04-25 22:13 ` [PATCH 1/8] mtd-utils: Fix return status in mtd_torture test function Richard Weinberger
2016-04-26 7:57 ` Boris Brezillon
2016-07-13 17:30 ` Brian Norris
2016-07-13 21:59 ` Richard Weinberger
2016-07-13 22:06 ` Brian Norris
2016-04-25 22:13 ` [PATCH 2/8] mtd-utils: Add multi-block erase function Richard Weinberger
2016-04-26 8:04 ` Boris Brezillon
2016-04-27 9:21 ` David Oberhollenzer
2016-04-27 9:27 ` Boris Brezillon [this message]
2016-04-25 22:13 ` [PATCH 3/8] mtd-utils: Add flash torture test utility Richard Weinberger
2016-04-26 8:13 ` Boris Brezillon
2016-04-26 14:34 ` Ezequiel Garcia
2016-04-27 9:28 ` David Oberhollenzer
2016-04-25 22:13 ` [PATCH 4/8] mtd-utils: Add flash stress test Utility Richard Weinberger
2016-04-26 8:18 ` Boris Brezillon
2016-04-26 9:22 ` Richard Weinberger
2016-04-26 9:47 ` Boris Brezillon
2016-04-27 16:38 ` Brian Norris
2016-04-25 22:13 ` [PATCH 5/8] mtd-utils: Add flash speed " Richard Weinberger
2016-04-25 22:13 ` [PATCH 6/8] mtd-utils: Add nand flash bit errors test Richard Weinberger
2016-04-25 22:13 ` [PATCH 7/8] mtd-utils: Add flash read test utility Richard Weinberger
2016-04-25 22:13 ` [PATCH 8/8] mtd-utils: Add nand page " Richard Weinberger
2016-04-26 3:13 ` [RFC] Porting kernel MTD tests to user space Ezequiel Garcia
2016-04-26 7:00 ` Richard Weinberger
2016-04-27 16:32 ` Brian Norris
2016-04-26 5:17 ` Artem Bityutskiy
2016-04-26 6:58 ` Richard Weinberger
2016-04-26 7:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427112727.0d767fac@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).