From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 17 May 2016 02:11:33 -0700 From: Christoph Hellwig To: Richard Weinberger Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, boris.brezillon@free-electrons.com, maxime.ripard@free-electrons.com, david@sigma-star.at, david@fromorbit.com, dedekind1@gmail.com, alex@nextthing.co, akpm@linux-foundation.org, sasha.levin@oracle.com, iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org, tony.luck@intel.com, shailendra.capricorn@gmail.com, kirill.shutemov@linux.intel.com, hughd@google.com, mgorman@techsingularity.net, vbabka@suse.cz Subject: Re: UBIFS and page migration (take 3) Message-ID: <20160517091133.GA23943@infradead.org> References: <1462974823-3168-1-git-send-email-richard@nod.at> <20160512114948.GA25113@infradead.org> <5739C0C1.1090907@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5739C0C1.1090907@nod.at> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 16, 2016 at 02:44:49PM +0200, Richard Weinberger wrote: > Is this a Reviewed-by? :-) I don't know the code well enough to feel qualified for a review. But you get my: Acked-by: Christoph Hellwig > There are two classes of issues: > a) filesystems that use buffer_migrate_page() but shouldn't > b) filesystems that don't implement ->migratepage() and fallback_migrate_page() > is not suitable. > > As starter we could kill the automatic assignment of fallback_migrate_page() and > non-buffer_head filesystems need to figure out whether fallback_migrate_page() > is suitable or not. > UBIFS found out the hard way. ;-\ Yes, I think this would be a good start.