Re: [PATCH v3 8/8] MTD: xway: add missing write_buf and read_buf to nand driver

Boris Brezillon
2016-06-19T16:33:08Z

On Sun, 19 Jun 2016 18:08:17 +0200
Hauke Mehrtens <hauke@hauke-m.de> wrote:

Still no descriptions...

> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/mtd/nand/xway_nand.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> index 282258f..8f208cb 100644
> --- a/drivers/mtd/nand/xway_nand.c
> +++ b/drivers/mtd/nand/xway_nand.c
> @@ -130,6 +130,22 @@ static unsigned char xway_read_byte(struct mtd_info *mtd)
> return xway_readb(mtd, NAND_READ_DATA);
> }
>
> +static void xway_read_buf(struct mtd_info *mtd, u_char *buf, int len)
> +{
> + int i;
> +
> + for (i = 0; i < len; i++)
> + buf[i] = xway_readb(mtd, NAND_WRITE_DATA);
> +}
> +
> +static void xway_write_buf(struct mtd_info *mtd, const u_char *buf, int len)
> +{
> + int i;
> +
> + for (i = 0; i < len; i++)
> + xway_writeb(mtd, NAND_WRITE_DATA, buf[i]);
> +}
> +
> /*
> * Probe for the NAND device.
> */
> @@ -162,6 +178,8 @@ static int xway_nand_probe(struct platform_device *pdev)
> data->chip.cmd_ctrl = xway_cmd_ctrl;
> data->chip.dev_ready = xway_dev_ready;
> data->chip.select_chip = xway_select_chip;
> + data->chip.write_buf = xway_write_buf;
> + data->chip.read_buf = xway_read_buf;
> data->chip.read_byte = xway_read_byte;
> data->chip.chip_delay = 30;
>