From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, john@phrozen.org
Subject: Re: [PATCH v5 0/8] MTD: xway: fix driver
Date: Fri, 24 Jun 2016 11:38:41 +0200 [thread overview]
Message-ID: <20160624113841.491f5c7b@bbrezillon> (raw)
In-Reply-To: <1466458334-10830-1-git-send-email-hauke@hauke-m.de>
On Mon, 20 Jun 2016 23:32:06 +0200
Hauke Mehrtens <hauke@hauke-m.de> wrote:
> Without these patches the driver does not work for me.
> Some of these patches are in OpenWrt for years now and should go
> upstream. In addition this converts it from some hack with the
> plat_nand driver to a normal platform driver.
>
> I will try to convert the spinlock to a mutex in a separate patch
> because this affects other parts of the kernel.
Applied the whole series. But please try to find a clean solution for
the spinlock issue.
Thanks,
Boris
>
> changes since:
> v4:
> - do not call NAND reset manually
>
> v3:
> - update some commit comments
> - reorder last 2 patches
> - do not set ->IO_ADDR_R/W any more
>
> v2:
> - reorder patches
> - use of_property_read_u32()
> - rework error handling in xway_nand_probe()
> - simplify latched command handling
> - remove xway_reset_chip()
> - remove cast of nandaddr
> - add nandaddr to xway_nand_data
> - add csflags to xway_nand_data
>
> v1:
> - convert to normal platform driver
> - do not use global variable xway_latchcmd
> - use mtd_to_nand()
>
> Hauke Mehrtens (6):
> mtd: nand: xway: add some more documentation
> mtd: nand: xway: convert to normal platform driver
> mtd: nand: xway: remove manual reset
> mtd: nand: xway: extract read and write function
> mtd: nand: xway: add missing write_buf and read_buf to nand driver
> mtd: nand: xway: add nandaddr to own struct
>
> John Crispin (2):
> mtd: nand: xway: Avoid messing up with IO_ADDR_W in ->cmd_ctrl()
> mtd: nand: xway: fix nand locking
>
> drivers/mtd/nand/Kconfig | 1 -
> drivers/mtd/nand/xway_nand.c | 231 ++++++++++++++++++++++++++-----------------
> 2 files changed, 141 insertions(+), 91 deletions(-)
>
prev parent reply other threads:[~2016-06-24 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 21:32 [PATCH v5 0/8] MTD: xway: fix driver Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 1/8] mtd: nand: xway: add some more documentation Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 2/8] mtd: nand: xway: convert to normal platform driver Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 3/8] mtd: nand: xway: Avoid messing up with IO_ADDR_W in ->cmd_ctrl() Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 4/8] mtd: nand: xway: remove manual reset Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 5/8] mtd: nand: xway: fix nand locking Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 6/8] mtd: nand: xway: extract read and write function Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 7/8] mtd: nand: xway: add missing write_buf and read_buf to nand driver Hauke Mehrtens
2016-06-20 21:32 ` [PATCH v5 8/8] mtd: nand: xway: add nandaddr to own struct Hauke Mehrtens
2016-06-24 9:38 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624113841.491f5c7b@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox