From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 29 Jun 2016 23:38:39 -0700 From: Christoph Hellwig To: Fam Zheng Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jens Axboe , "Ed L. Cashin" , Jiri Kosina , "Michael S. Tsirkin" , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Shaohua Li , Ulf Hansson , David Woodhouse , Brian Norris , Keith Busch , linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, dan.j.williams@intel.com Subject: Re: [PATCH v2 00/12] gendisk: Generate uevent after attribute available Message-ID: <20160630063839.GA17205@infradead.org> References: <20160630015953.6888-1-famz@redhat.com> <20160630062442.GA19761@infradead.org> <20160630063554.GE23296@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160630063554.GE23296@ad.usersys.redhat.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jun 30, 2016 at 02:35:54PM +0800, Fam Zheng wrote: > also more code and less flexible IMO. For example, we need at least two > variants, for attribute_group and device_attribute separately, right? Yes, or maybe just a calling convention that just passes both.