From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLAlE-0005N6-0I for linux-mtd@lists.infradead.org; Thu, 07 Jul 2016 14:58:40 +0000 Date: Thu, 7 Jul 2016 16:58:05 +0200 From: Boris Brezillon To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH 5/5] mtd: Don't print a scary message when trying to remove a busy MTD Message-ID: <20160707165805.636d1b47@bbrezillon> In-Reply-To: <1467669983-12105-6-git-send-email-richard@nod.at> References: <1467669983-12105-1-git-send-email-richard@nod.at> <1467669983-12105-6-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 5 Jul 2016 00:06:23 +0200 Richard Weinberger wrote: > Just return -EBUSY and everything is fine. > > Signed-off-by: Richard Weinberger > --- > drivers/mtd/mtdcore.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index f49e103..f2dea88 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -499,11 +499,9 @@ int del_mtd_device(struct mtd_info *mtd) > goto out_error; > } > > - if (mtd->usecount) { > - printk(KERN_NOTICE "Removing MTD device #%d (%s) with use count %d\n", > - mtd->index, mtd->name, mtd->usecount); > + if (mtd->usecount) > ret = -EBUSY; > - } else { > + else { Nit: can you keep the brackets around the if (mtd->usecount) block (we usually only drop them when both the 'if' and 'else' blocks contain a single instruction)? > /* No need to get a refcount on the module containing > the notifier, since we hold the mtd_table_mutex */ > list_for_each_entry(not, &mtd_notifiers, list)