[PATCH] mtd: Remove unused symbol CONFIG_MTDRAM_ABS_POS

[PATCH] mtd: Remove unused symbol CONFIG_MTDRAM_ABS_POS

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]

This has been unused, except as the condition for a fatal error, since
commit c13cbf3b5086 ("[MTD] mtdram: Quick cleanup of the driver:") in
2.6.13 (!).

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 arch/cris/arch-v10/drivers/axisflashmap.c |  2 +-
 drivers/mtd/devices/Kconfig               | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/arch/cris/arch-v10/drivers/axisflashmap.c b/arch/cris/arch-v10/drivers/axisflashmap.c
index 60d57c590032..bdc25aa43468 100644
--- a/arch/cris/arch-v10/drivers/axisflashmap.c
+++ b/arch/cris/arch-v10/drivers/axisflashmap.c
@@ -397,7 +397,7 @@ static int __init init_axis_flash(void)
 	if (!romfs_in_flash) {
 		/* Create an RAM device for the root partition (romfs). */
 
-#if !defined(CONFIG_MTD_MTDRAM) || (CONFIG_MTDRAM_TOTAL_SIZE != 0) || (CONFIG_MTDRAM_ABS_POS != 0)
+#if !defined(CONFIG_MTD_MTDRAM) || (CONFIG_MTDRAM_TOTAL_SIZE != 0)
 		/* No use trying to boot this kernel from RAM. Panic! */
 		printk(KERN_EMERG "axisflashmap: Cannot create an MTD RAM "
 		       "device due to kernel (mis)configuration!\n");
diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index f73c41697a00..5a1d0dc71495 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -171,18 +171,6 @@ config MTDRAM_ERASE_SIZE
 	  as a module, it is also possible to specify this as a parameter when
 	  loading the module.
 
-#If not a module (I don't want to test it as a module)
-config MTDRAM_ABS_POS
-	hex "SRAM Hexadecimal Absolute position or 0"
-	depends on MTD_MTDRAM=y
-	default "0"
-	help
-	  If you have system RAM accessible by the CPU but not used by Linux
-	  in normal operation, you can give the physical address at which the
-	  available RAM starts, and the MTDRAM driver will use it instead of
-	  allocating space from Linux's available memory. Otherwise, leave
-	  this set to zero. Most people will want to leave this as zero.
-
 config MTD_BLOCK2MTD
 	tristate "MTD using block device"
 	depends on BLOCK

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

Re: [PATCH] mtd: Remove unused symbol CONFIG_MTDRAM_ABS_POS

[Jesper Nilsson]

On Fri, Jun 03, 2016 at 01:06:27AM +0100, Ben Hutchings wrote:
> This has been unused, except as the condition for a fatal error, since
> commit c13cbf3b5086 ("[MTD] mtdram: Quick cleanup of the driver:") in
> 2.6.13 (!).

Agreed,

Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

Re: [PATCH] mtd: Remove unused symbol CONFIG_MTDRAM_ABS_POS

[Brian Norris]

On Fri, Jun 03, 2016 at 01:06:27AM +0100, Ben Hutchings wrote:
> This has been unused, except as the condition for a fatal error, since
> commit c13cbf3b5086 ("[MTD] mtdram: Quick cleanup of the driver:") in
> 2.6.13 (!).
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
>  arch/cris/arch-v10/drivers/axisflashmap.c |  2 +-
>  drivers/mtd/devices/Kconfig               | 12 ------------
>  2 files changed, 1 insertion(+), 13 deletions(-)

You missed a usage in arch/cris/arch-v32/drivers/axisflashmap.c. Applied
with the following diff:

diff --git a/arch/cris/arch-v32/drivers/axisflashmap.c b/arch/cris/arch-v32/drivers/axisflashmap.c
index bd10d3ba0949..87656c41fec7 100644
--- a/arch/cris/arch-v32/drivers/axisflashmap.c
+++ b/arch/cris/arch-v32/drivers/axisflashmap.c
@@ -320,7 +320,7 @@ static int __init init_axis_flash(void)
 	 * but its size must be configured as 0 so as not to conflict
 	 * with our usage.
 	 */
-#if !defined(CONFIG_MTD_MTDRAM) || (CONFIG_MTDRAM_TOTAL_SIZE != 0) || (CONFIG_MTDRAM_ABS_POS != 0)
+#if !defined(CONFIG_MTD_MTDRAM) || (CONFIG_MTDRAM_TOTAL_SIZE != 0)
 	if (!romfs_in_flash && !nand_boot) {
 		printk(KERN_EMERG "axisflashmap: Cannot create an MTD RAM "
 		       "device; configure CONFIG_MTD_MTDRAM with size = 0!\n");