From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bNNzk-000445-QG for linux-mtd@lists.infradead.org; Wed, 13 Jul 2016 17:30:49 +0000 Received: by mail-pf0-x244.google.com with SMTP id i123so3449924pfg.3 for ; Wed, 13 Jul 2016 10:30:28 -0700 (PDT) Date: Wed, 13 Jul 2016 10:30:24 -0700 From: Brian Norris To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, david.oberhollenzer@sigma-star.at, Boris Brezillon Subject: Re: [PATCH 1/8] mtd-utils: Fix return status in mtd_torture test function Message-ID: <20160713173024.GA10487@google.com> References: <1461622409-14970-1-git-send-email-richard@nod.at> <1461622409-14970-2-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461622409-14970-2-git-send-email-richard@nod.at> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Apr 26, 2016 at 12:13:22AM +0200, Richard Weinberger wrote: > From: David Oberhollenzer > > This patch fixes the return status of the mtd_torture function > in libmtd. > > The torture test function is currently only used by the ubiformat > utilitiy to check if a block is bad after a write fails (blocks are > marked bad if the function returns an error status). However, the > way the function was written, it ALWAYS returns an error value > irregardless of whether it failed or not. > > Signed-off-by: David Oberhollenzer > Signed-off-by: Richard Weinberger Seems like everyone's reviewed this, but no one applied it. (Richard, did we get you push access to mtd-utils yet?) Applied patch 1. Brian