* [patch] mtd: nand: omap2: Cleanup a curly brace issue
@ 2016-07-14 21:26 Dan Carpenter
2016-07-14 21:31 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-07-14 21:26 UTC (permalink / raw)
To: Boris Brezillon, Teresa Remmet
Cc: Richard Weinberger, David Woodhouse, Brian Norris, linux-mtd,
kernel-janitors
It doesn't affect runtime, but curly braces were obviously intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index a36ad3d..ab7c340 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info)
/* detect availability of ELM module. Won't be present pre-OMAP4 */
info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0);
- if (!info->elm_of_node)
+ if (!info->elm_of_node) {
info->elm_of_node = of_parse_phandle(child, "elm_id", 0);
if (!info->elm_of_node)
dev_dbg(dev, "ti,elm-id not in DT\n");
+ }
/* select ecc-scheme for NAND */
if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mtd: nand: omap2: Cleanup a curly brace issue
2016-07-14 21:26 [patch] mtd: nand: omap2: Cleanup a curly brace issue Dan Carpenter
@ 2016-07-14 21:31 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2016-07-14 21:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Boris Brezillon, Teresa Remmet, Richard Weinberger,
David Woodhouse, linux-mtd, kernel-janitors, Arnd Bergmann
On Fri, Jul 15, 2016 at 12:26:08AM +0300, Dan Carpenter wrote:
> It doesn't affect runtime, but curly braces were obviously intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, but you're just a tad late ;)
http://patchwork.ozlabs.org/patch/648283/
Nice to point out that technically, the behavior doesn't really change
though.
Brian
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index a36ad3d..ab7c340 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info)
>
> /* detect availability of ELM module. Won't be present pre-OMAP4 */
> info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0);
> - if (!info->elm_of_node)
> + if (!info->elm_of_node) {
> info->elm_of_node = of_parse_phandle(child, "elm_id", 0);
> if (!info->elm_of_node)
> dev_dbg(dev, "ti,elm-id not in DT\n");
> + }
>
> /* select ecc-scheme for NAND */
> if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-14 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-14 21:26 [patch] mtd: nand: omap2: Cleanup a curly brace issue Dan Carpenter
2016-07-14 21:31 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).