From: Daniel Golle <daniel@makrotopia.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH for-4.8] ubifs: silence early error messages if MS_SILENT is set
Date: Tue, 19 Jul 2016 14:36:52 +0200 [thread overview]
Message-ID: <20160719123651.GB1716@makrotopia.org> (raw)
In-Reply-To: <578E1D02.3000109@nod.at>
Hi Richard,
On Tue, Jul 19, 2016 at 02:28:50PM +0200, Richard Weinberger wrote:
> ...
> >> The diff makes sense but not the commit message.
> >
> > More brief? Less reasoning? Please elaborate, so I know what to
> > improve.
>
> It confused me a bit. :-)
Feel free to change it or let me know if I should reword it and
resend the patch.
>
> >> Why would you mount a squashfs on top of UBI as UBIFS?
> >> We have rootfstype= for this.
> >
> > However, in OpenWrt/LEDE users may choose the fstype (UBIFS and
> > squashfs) used for rootfs and the kernel should auto-probe just like
> > it does for block or MTD devices (we support JFFS2 and squashfs
> > on NOR and SPI flashes). In the case of squashfs being a read-only
> > filesystem, an overlayfs is automatically created and used.
> > Changing kernel command line parameters or anything which would
> > require bootloader access is not an option for most of our users, due
> > to the bootloaders being locked or because not everyone is into hooking
> > up a serial console.
> > Also, many stock bootloaders append stuff to the cmdline unwanted
> > when using vanilla or OpenWrt's kernel. Thus, we often times ignore
> > the bootloader's bootargs.
> > The strategy of probe-mounting is working well as filesystems can
> > easily be identified. The reason for this patch is that some users are
> > getting confused about lines in in their bootlog indicating an error
> > eventhough there wasn't anything bad happening.
>
> Ah that kind of kludges again...
>
> Anyway, patch looks good to me.
>
> BTW: We should rename ubifs_errc(), commit 235c362bd (UBIFS: extend debug/message capabilities)
> added the UBIFS context object to all logging functions.
... or at least the just comment above the macro definition.
'c' could stand for 'conditional' ;)
Cheers
Daniel
next prev parent reply other threads:[~2016-07-19 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 22:26 [PATCH for-4.8] ubifs: silence early error messages if MS_SILENT is set Daniel Golle
2016-07-19 5:38 ` Richard Weinberger
2016-07-19 12:20 ` Daniel Golle
2016-07-19 12:28 ` Richard Weinberger
2016-07-19 12:36 ` Daniel Golle [this message]
2016-07-25 11:44 ` [PATCH] ubifs: update comment for ubifs_errc Daniel Golle
2016-07-25 20:43 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719123651.GB1716@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).