From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Mason <slash.tmp@free.fr>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Richard Weinberger <richard@nod.at>,
Sebastian Frias <sf84@laposte.net>,
Jean-Baptiste Lescher <jblescher@gmail.com>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>
Subject: Re: [PATCH v3] mtd: nand: tango: import driver for tango chips
Date: Mon, 12 Sep 2016 21:08:10 +0200 [thread overview]
Message-ID: <20160912210810.79ac23c9@bbrezillon> (raw)
In-Reply-To: <57D5530B.2060209@free.fr>
On Sun, 11 Sep 2016 14:50:19 +0200
Mason <slash.tmp@free.fr> wrote:
> On 09/09/2016 18:13, Marc Gonzalez wrote:
>
> > This driver supports the NAND Flash controller embedded in recent
> > Tango chips, such as SMP8758 and SMP8759.
> >
> > Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> > ---
> > drivers/mtd/nand/Kconfig | 6 +
> > drivers/mtd/nand/Makefile | 1 +
> > drivers/mtd/nand/tango_nand.c | 482 ++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 489 insertions(+)
> > create mode 100644 drivers/mtd/nand/tango_nand.c
>
> Still on the TODO/MAYBE list:
>
> 1) Remove the cast in tango_write_page
Nice to have (especially since it's not required at all: do_dma() can
take a const void *)
> 2) Update stats.failed
Mandatory.
> 3) Implement read/write_oob
Mandatory. I've seen your questions on the #mtd chan regarding the
usefulness of ->read/write_oob(). I agree that most of the time it's
not needed, but some MTD users depends on it.
> 4) Report OOB layout to framework (?)
Mandatory. For the exact same reason.
> 5) Tweak (?) Peripheral Bus setup (timings and CS config)
That's up to you, but I'd recommend to sort this out before submitting
the next version.
> 6) Write device_cfg register (or report weirdness as a bug)
I don't get this one.
next prev parent reply other threads:[~2016-09-12 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 10:02 [PATCH v1] mtd: nand: tango: import driver for tango controller Marc Gonzalez
2016-09-05 7:14 ` Boris Brezillon
2016-09-05 10:18 ` Mason
2016-09-05 11:15 ` Boris Brezillon
2016-09-08 15:55 ` [PATCH v2] mtd: nand: tango: import driver for tango chips Marc Gonzalez
2016-09-08 16:37 ` Marc Gonzalez
2016-09-09 16:13 ` [PATCH v3] " Marc Gonzalez
2016-09-11 12:50 ` Mason
2016-09-12 19:08 ` Boris Brezillon [this message]
2016-09-19 13:12 ` [PATCH v5] " Marc Gonzalez
2016-09-19 15:57 ` Marc Gonzalez
2016-09-19 17:06 ` Boris Brezillon
2016-09-19 22:37 ` Mason
2016-09-20 7:24 ` Boris Brezillon
2016-09-20 7:39 ` Artem Bityutskiy
2016-09-20 7:57 ` Richard Weinberger
2016-09-21 16:45 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912210810.79ac23c9@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=jblescher@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=richard@nod.at \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).