From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Richard Weinberger <richard@nod.at>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PULL] mtd: nand: material for 4.9
Date: Mon, 3 Oct 2016 09:55:33 -0700 [thread overview]
Message-ID: <20161003165533.GA66959@google.com> (raw)
In-Reply-To: <20160925205326.67b5a9bd@bbrezillon>
Hi Boris,
On Sun, Sep 25, 2016 at 08:53:26PM +0200, Boris Brezillon wrote:
> Hi Brian,
>
> Here is my PR for 4.9. Let me know if you see any problem.
> Also, please let us know ahead of time if you can't take this PR (I know you
> are busy lately, and I guess I could send this PR directly to Linus or ask
> Richard to take it in its UBIFS/UBI tree).
I made some time for this one. We'll see about the pairing one
(hopefully trivial? but I'm not sure if there's value in merging without
users).
> Thanks,
>
> Boris
>
> The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc:
>
> Linux 4.8-rc1 (2016-08-07 18:18:00 -0700)
>
> are available in the git repository at:
>
> git@github.com:linux-nand/linux.git tags/for-4.9
>
> for you to fetch changes up to d44154f969a44269a9288c274c1c2fd9e85df8a5:
>
> mtd: nand: Provide nand_cleanup() function to free NAND related resources (2016-09-23 09:35:16 +0200)
Thanks. I only added one trivial fixup that checkpatch.pl's spelling.txt
(what??) caught:
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 7a00245ebada..e5718e5ecf92 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -746,7 +746,7 @@ static void nand_command_lp(struct mtd_info *mtd, unsigned int command,
chip->cmd_ctrl(mtd, column, ctrl);
ctrl &= ~NAND_CTRL_CHANGE;
- /* Only ouput a single addr cycle for 8bits opcodes. */
+ /* Only output a single addr cycle for 8bits opcodes. */
if (!nand_opcode_8bits(command))
chip->cmd_ctrl(mtd, column >> 8, ctrl);
}
> ----------------------------------------------------------------
> Notable core changes:
> - add the infrastructure to automate NAND timings configuration
> - provide a generic DT property to maximize ECC strength
>
> The rest is just a bunch of minor drivers and core fixes/cleanup
> patches.
>
> ----------------------------------------------------------------
I added a small note in the merge commit about the BBT changes you made.
That's an especially fragile piece of code I think (and used by every
NAND driver), but it looked OK to me.
Brian
next prev parent reply other threads:[~2016-10-03 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 18:53 [PULL] mtd: nand: material for 4.9 Boris Brezillon
2016-10-03 16:55 ` Brian Norris [this message]
2016-10-03 17:38 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003165533.GA66959@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).