From: Dan Carpenter <dan.carpenter@oracle.com>
To: shengyong1@huawei.com
Cc: linux-mtd@lists.infradead.org
Subject: [bug report] UBI: Fastmap: Do not add vol if it already exists
Date: Tue, 25 Oct 2016 23:46:07 +0300 [thread overview]
Message-ID: <20161025204607.GA27826@elgon.mountain> (raw)
Hello shengyong,
The patch e96a8a3bb671: "UBI: Fastmap: Do not add vol if it already
exists" from May 26, 2015, leads to the following static checker
warning:
drivers/mtd/ubi/fastmap.c:712 ubi_attach_fastmap()
warn: PTR_ERR(av) is never (-22)
drivers/mtd/ubi/fastmap.c
703
704 av = add_vol(ai, be32_to_cpu(fmvhdr->vol_id),
705 be32_to_cpu(fmvhdr->used_ebs),
706 be32_to_cpu(fmvhdr->data_pad),
707 fmvhdr->vol_type,
708 be32_to_cpu(fmvhdr->last_eb_bytes));
709
710 if (!av)
711 goto fail_bad;
712 if (PTR_ERR(av) == -EINVAL) {
av is either -EEXIST or -ENOMEM. It's never -EINVAL.
713 ubi_err(ubi, "volume (ID %i) already exists",
714 fmvhdr->vol_id);
715 goto fail_bad;
716 }
717
regards,
dan carpenter
next reply other threads:[~2016-10-25 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 20:46 Dan Carpenter [this message]
2016-10-26 1:46 ` [bug report] UBI: Fastmap: Do not add vol if it already exists Sheng Yong
2016-10-26 8:25 ` Dan Carpenter
2016-10-26 9:23 ` Boris Brezillon
2016-10-26 11:30 ` Sheng Yong
2016-10-26 11:28 ` Sheng Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025204607.GA27826@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shengyong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).