From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Subject: Re: [PATCH 0/2] mtd: nand: Enforce tCCS wait time after a column change
Date: Fri, 28 Oct 2016 10:54:25 +0200 [thread overview]
Message-ID: <20161028105425.61868d75@bbrezillon> (raw)
In-Reply-To: <1475310243-32625-1-git-send-email-boris.brezillon@free-electrons.com>
On Sat, 1 Oct 2016 10:24:01 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> Hi,
>
> Marc recently struggled with the RNDIN/RNDOUT commands when trying to
> add support for the Tango NAND controller.
> After some investigation it appeared that nothing in the
> nand_command_lp() code waits tCCS, which is required to make sure the
> NAND chip is ready to receive/send data on the bus after a column
> change.
>
> This series adds some more timings to the nand_sdr_timings struct
> (including tCCS) and try to extract them from the ONFI parameter table
> (if available).
>
> It then adds a new flags to ask the core to enforce the tCCS
> constraint.
> As noted in the commit message, this is an opt-in flag to avoid perf
> regressions on existing implementations (adding an ndelay() might be
> useless if the controller IP or driver already takes care of that),
> but it might appear that some implementations are actually broken and
> needs this flag as well.
Applied.
>
> Regards,
>
> Boris
>
> Boris Brezillon (2):
> mtd: nand: Add a few more timings to nand_sdr_timings
> mtd: nand: Wait tCCS after a column change
>
> drivers/mtd/nand/nand_base.c | 26 +++++++++++++++++++++++++-
> drivers/mtd/nand/nand_timings.c | 26 +++++++++++++++++++++++++-
> include/linux/mtd/nand.h | 18 ++++++++++++++++++
> 3 files changed, 68 insertions(+), 2 deletions(-)
>
prev parent reply other threads:[~2016-10-28 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 8:24 [PATCH 0/2] mtd: nand: Enforce tCCS wait time after a column change Boris Brezillon
2016-10-01 8:24 ` [PATCH 1/2] mtd: nand: Add a few more timings to nand_sdr_timings Boris Brezillon
2016-10-01 8:24 ` [PATCH 2/2] mtd: nand: Wait tCCS after a column change Boris Brezillon
2016-10-25 12:31 ` [PATCH 0/2] mtd: nand: Enforce tCCS wait time " Marc Gonzalez
2016-10-28 8:54 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028105425.61868d75@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox