* [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX
@ 2016-11-20 15:09 Rafał Miłecki
2016-11-22 19:45 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2016-11-20 15:09 UTC (permalink / raw)
To: linux-mtd
Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-kernel,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
After parsing TRX we should skip to the first block placed behind it.
Our code was working only with TRX with length not aligned to the
blocksize. In other cases (length aligned) it was missing the block
places right after TRX.
This fixes calculation and simplifies the comment.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/mtd/bcm47xxpart.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c
index 3779475..283ff7e 100644
--- a/drivers/mtd/bcm47xxpart.c
+++ b/drivers/mtd/bcm47xxpart.c
@@ -229,12 +229,10 @@ static int bcm47xxpart_parse(struct mtd_info *master,
last_trx_part = curr_part - 1;
- /*
- * We have whole TRX scanned, skip to the next part. Use
- * roundown (not roundup), as the loop will increase
- * offset in next step.
- */
- offset = rounddown(offset + trx->length, blocksize);
+ /* Jump to the end of TRX */
+ offset = roundup(offset + trx->length, blocksize);
+ /* Next loop iteration will increase the offset */
+ offset -= blocksize;
continue;
}
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX
2016-11-20 15:09 [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX Rafał Miłecki
@ 2016-11-22 19:45 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2016-11-22 19:45 UTC (permalink / raw)
To: Rafał Miłecki
Cc: linux-mtd, David Woodhouse, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-kernel,
Rafał Miłecki
On Sun, Nov 20, 2016 at 04:09:30PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> After parsing TRX we should skip to the first block placed behind it.
> Our code was working only with TRX with length not aligned to the
> blocksize. In other cases (length aligned) it was missing the block
> places right after TRX.
>
> This fixes calculation and simplifies the comment.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-22 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-20 15:09 [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX Rafał Miłecki
2016-11-22 19:45 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).