From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Colin King <colin.king@canonical.com>,
David Woodhouse <dwmw2@infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"
Date: Tue, 22 Nov 2016 14:46:15 -0800 [thread overview]
Message-ID: <20161122224615.GJ77253@google.com> (raw)
In-Reply-To: <1479850347.1942.24.camel@perches.com>
On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote:
> On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote:
> > Thanks, these all look good but:
> >
> > (a) you didn't provide a Signed-off-by and
> > (b) your patch is full of non-breaking spaces (0xA0), instead of proper
> > ASCII spaces (0x20)
> >
> > I feel like we've had this conversation before about your Evolution
> > mailer a long time ago; you still haven't fixed that?
> >
> > I'm sorry, but I just can't take your patch. I'm not going to hand-edit
> > this one...
>
> No worries, it was an unsigned patch suggestion, not
> a formal patch. I know the difference.
OK, understood.
> And have you ever looked at the evolution source code?
> At best, it's pretty convoluted.
> There's _no way_ I want to touch it.
I haven't looked. But by "fixed" I guess I meant "fixed your workflow" :)
Regards,
Brian
next prev parent reply other threads:[~2016-11-22 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 18:25 [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure" Colin King
2016-10-28 18:51 ` Joe Perches
2016-11-22 19:37 ` Brian Norris
2016-11-22 21:32 ` Joe Perches
2016-11-22 22:46 ` Brian Norris [this message]
2016-11-22 19:49 ` Brian Norris
-- strict thread matches above, loose matches on Subject: below --
2016-10-28 18:35 Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122224615.GJ77253@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).