From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cCQbi-0006xE-S8 for linux-mtd@lists.infradead.org; Thu, 01 Dec 2016 12:36:59 +0000 Date: Thu, 1 Dec 2016 13:36:27 +0100 From: Boris Brezillon To: Hauke Mehrtens Cc: richard@nod.at, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, john@phrozen.org, cyrille.pitchen@atmel.com, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH] mtd: nand: xway: fix build undefined MODULE_DEVICE_TABLE() Message-ID: <20161201133627.38953fb0@bbrezillon> In-Reply-To: <20161130225110.10759-1-hauke@hauke-m.de> References: <20161130225110.10759-1-hauke@hauke-m.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Hauke, On Wed, 30 Nov 2016 23:51:10 +0100 Hauke Mehrtens wrote: > The header file with the definition of MODULE_DEVICE_TABLE() was > missing, add include for linux/module.h to fix the problem in 4.9. I tried to enable this driver as a module, and the build failed because of a missing symbol (see the following patch). Now, if it's not supposed to be compiled as a module, then you should modify the Kconfig accordingly. Regards, Boris --->8--- diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index 236193b5210b..29e753556597 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -156,6 +156,7 @@ static void __iomem *pmu_membase; static void __iomem *ltq_xbar_membase; void __iomem *ltq_cgu_membase; void __iomem *ltq_ebu_membase; +EXPORT_SYMBOL(ltq_ebu_membase); static u32 ifccr = CGU_IFCCR; static u32 pcicr = CGU_PCICR;