From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: fix typos in ooblayout comment blocks
Date: Wed, 14 Dec 2016 08:06:57 +0100 [thread overview]
Message-ID: <20161214080657.60e658cf@bbrezillon> (raw)
In-Reply-To: <1481675461-19364-1-git-send-email-yamada.masahiro@socionext.com>
On Wed, 14 Dec 2016 09:31:01 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> - "This functions return ..." -> "This function returns ..."
> - "I you want ..." -> "If you want ..."
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>
> drivers/mtd/mtdcore.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index ca661ce..d64e61b 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1129,7 +1129,7 @@ EXPORT_SYMBOL_GPL(mtd_write_oob);
> * @oobecc: OOB region struct filled with the appropriate ECC position
> * information
> *
> - * This functions return ECC section information in the OOB area. I you want
> + * This function returns ECC section information in the OOB area. If you want
> * to get all the ECC bytes information, then you should call
> * mtd_ooblayout_ecc(mtd, section++, oobecc) until it returns -ERANGE.
> *
> @@ -1161,7 +1161,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_ecc);
> * @oobfree: OOB region struct filled with the appropriate free position
> * information
> *
> - * This functions return free bytes position in the OOB area. I you want
> + * This function returns free bytes position in the OOB area. If you want
> * to get all the free bytes information, then you should call
> * mtd_ooblayout_free(mtd, section++, oobfree) until it returns -ERANGE.
> *
> @@ -1191,7 +1191,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_free);
> * @iter: iterator function. Should be either mtd_ooblayout_free or
> * mtd_ooblayout_ecc depending on the region type you're searching for
> *
> - * This functions returns the section id and oobregion information of a
> + * This function returns the section id and oobregion information of a
> * specific byte. For example, say you want to know where the 4th ECC byte is
> * stored, you'll use:
> *
next prev parent reply other threads:[~2016-12-14 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 0:31 [PATCH] mtd: fix typos in ooblayout comment blocks Masahiro Yamada
2016-12-14 7:06 ` Boris Brezillon [this message]
2017-02-07 4:58 ` Masahiro Yamada
2017-02-08 21:32 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214080657.60e658cf@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).