From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.free-electrons.com ([62.4.15.54])
 by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))
 id 1cQrvq-0001sf-RD
 for linux-mtd@lists.infradead.org; Tue, 10 Jan 2017 08:37:28 +0000
Date: Tue, 10 Jan 2017 09:37:05 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>, linux-mtd@lists.infradead.org,
 Brian Norris <computersforpeace@gmail.com>, Richard Weinberger
 <richard@nod.at>
Subject: Re: [PATCH v1 1/1] UBI: Fix section mismatch
Message-ID: <20170110093705.6310e828@bbrezillon>
In-Reply-To: <1483990466.26691.47.camel@linux.intel.com>
References: <20170109181004.195157-1-andriy.shevchenko@linux.intel.com>
 <1483990466.26691.47.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Mon, 09 Jan 2017 21:34:26 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, 2017-01-09 at 20:10 +0200, Andy Shevchenko wrote:
> > WARNING: vmlinux.o(.text+0x1f2a80): Section mismatch in reference from
> > the variable __param_ops_mtd to the function
> > .init.text:ubi_mtd_param_parse()
> > The function __param_ops_mtd() references
> > the function __init ubi_mtd_param_parse().
> > This is often because __param_ops_mtd lacks a __init
> > annotation or the annotation of ubi_mtd_param_parse is wrong. =20
>=20
> Please, discard this. It fixes one and add another.

Just remove the __initdata specifiers on mtd_devs and mtd_dev_param and
you should be fine.

>=20
> >=20
> > Cc: Richard Weinberger <richard@nod.at>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > =C2=A0drivers/mtd/ubi/build.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> > index 85d54f37e28f..00a46ff61528 100644
> > --- a/drivers/mtd/ubi/build.c
> > +++ b/drivers/mtd/ubi/build.c
> > @@ -1389,7 +1389,7 @@ static int __init bytes_str_to_int(const char
> > *str)
> > =C2=A0 * This function returns zero in case of success and a negative e=
rror
> > code in
> > =C2=A0 * case of error.
> > =C2=A0 */
> > -static int __init ubi_mtd_param_parse(const char *val, struct
> > kernel_param *kp)
> > +static int ubi_mtd_param_parse(const char *val, struct kernel_param
> > *kp)
> > =C2=A0{
> > =C2=A0	int i, len;
> > =C2=A0	struct mtd_dev_param *p; =20
>=20