From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp1040.oracle.com ([156.151.31.81]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cRbYq-0007YG-Bn for linux-mtd@lists.infradead.org; Thu, 12 Jan 2017 09:20:47 +0000 Date: Thu, 12 Jan 2017 12:19:26 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 03/18] mtd-cfi_cmdset_0001: Add some spaces for better code readability Message-ID: <20170112091926.GA15314@mwanda> References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 11, 2017 at 09:38:18PM +0100, SF Markus Elfring wrote: > - for (i=0; icfiq->NumEraseRegions; i++) > - for (j=0; jnumchips; j++) > - kfree(mtd->eraseregions[(j*cfi->cfiq->NumEraseRegions)+i].lockmap); > + for (i = 0; i < cfi->cfiq->NumEraseRegions; i++) > + for (j = 0; j < cfi->numchips; j++) > + kfree(mtd->eraseregions[j > + * cfi->cfiq > + ->NumEraseRegions > + + i].lockmap); No. regards, dan carpenter