From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Brian Norris" <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
Sascha Hauer <s.hauer@pengutronix.de>,
Moritz Fischer <moritz.fischer@ettus.com>
Subject: Re: [PATCH] mtd: Add partition device node to mtd partition devices
Date: Thu, 9 Feb 2017 16:34:58 +0100 [thread overview]
Message-ID: <20170209163458.41b3bea7@bbrezillon> (raw)
In-Reply-To: <20170209105024.1579-1-u.kleine-koenig@pengutronix.de>
+Moritz
On Thu, 9 Feb 2017 11:50:24 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> The user visible change here is that mtd partitions get an of_node link
> in sysfs.
The same patch has already been posted last year [1].
Brian, can we take one of these?
[1]https://patchwork.ozlabs.org/patch/625978/
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mtd/mtdpart.c | 1 +
> drivers/mtd/ofpart.c | 1 +
> include/linux/mtd/partitions.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index fccdd49bb964..d0b919ab85c0 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -424,6 +424,7 @@ static struct mtd_part *allocate_partition(struct mtd_info *master,
> slave->mtd.dev.parent = IS_ENABLED(CONFIG_MTD_PARTITIONED_MASTER) ?
> &master->dev :
> master->dev.parent;
> + slave->mtd.dev.of_node = part->of_node;
>
> slave->mtd._read = part_read;
> slave->mtd._write = part_write;
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index ede407d6e106..464470122493 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -108,6 +108,7 @@ static int parse_ofpart_partitions(struct mtd_info *master,
>
> parts[i].offset = of_read_number(reg, a_cells);
> parts[i].size = of_read_number(reg + a_cells, s_cells);
> + parts[i].of_node = pp;
>
> partname = of_get_property(pp, "label", &len);
> if (!partname)
> diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
> index 70736e1e6c8f..06df1e06b6e0 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -41,6 +41,7 @@ struct mtd_partition {
> uint64_t size; /* partition size */
> uint64_t offset; /* offset within the master MTD space */
> uint32_t mask_flags; /* master MTD flags to mask out for this partition */
> + struct device_node *of_node;
> };
>
> #define MTDPART_OFS_RETAIN (-3)
next prev parent reply other threads:[~2017-02-09 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 10:50 [PATCH] mtd: Add partition device node to mtd partition devices Uwe Kleine-König
2017-02-09 15:34 ` Boris Brezillon [this message]
2017-02-09 19:39 ` Uwe Kleine-König
2017-02-09 19:59 ` Boris Brezillon
2017-02-09 20:14 ` Uwe Kleine-König
2017-02-09 20:41 ` Boris Brezillon
2017-02-10 3:19 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209163458.41b3bea7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=moritz.fischer@ettus.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).