Re: [PATCH] mtd: Add partition device node to mtd partition devices

[Boris Brezillon <boris.brezillon@free-electrons.com>]

On Thu, 9 Feb 2017 20:39:40 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> On Thu, Feb 09, 2017 at 04:34:58PM +0100, Boris Brezillon wrote:
> > +Moritz
> > 
> > On Thu,  9 Feb 2017 11:50:24 +0100
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >   
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > 
> > > The user visible change here is that mtd partitions get an of_node link
> > > in sysfs.  
> > 
> > The same patch has already been posted last year [1].
> > Brian, can we take one of these?
> > 
> > [1]https://patchwork.ozlabs.org/patch/625978/  
> 
> Moritz' patch is more lame, it even updates the documentation (ok, one
> point for Moriz :-) Other than that the only difference is "node" vs.
> "of_node" (half a point for Sascha) and the position of the assignment
> in mtdpart.c has a different position (another half point for Sascha).
> 
> If that would be liked to be seen I can volunteer to create a patch
> picking the best from both sources.

Sure, you can also add my ack (which I already put on Moritz patch).
BTW, is the of_node link in sysfs the only motivation for this change?
I know Moritz had bigger plans (nvmem blocks on top of MTD devices), and
I also considered advanced stuff (like per-partition ECC config) which
required having a valid ->of_node on slave MTD devices.

Thanks,

Boris