From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.free-electrons.com ([62.4.15.54])
 by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))
 id 1cd1yC-00077y-R2
 for linux-mtd@lists.infradead.org; Sun, 12 Feb 2017 21:46:11 +0000
Date: Sun, 12 Feb 2017 22:45:43 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>, Marek Vasut
 <marek.vasut@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Brian
 Norris <computersforpeace@gmail.com>, Richard Weinberger <richard@nod.at>,
 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi-nor: use ERR_CAST in return
Message-ID: <20170212224543.34f4227a@bbrezillon>
In-Reply-To: <1486917823-23569-1-git-send-email-der.herr@hofr.at>
References: <1486917823-23569-1-git-send-email-der.herr@hofr.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Sun, 12 Feb 2017 17:43:43 +0100
Nicholas Mc Guire <der.herr@hofr.at> wrote:

> This fixes a sparse warning about 

Your commit message seems to be incomplete.

Once fixed,

Acked-by: Boris Brezillon <boris.brezilon@free-electrons.com>

> 
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> 
> sparse complained about:
> drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
> drivers/mtd/spi-nor/intel-spi.c:731:28:    expected struct intel_spi *
> drivers/mtd/spi-nor/intel-spi.c:731:28:    got void [noderef] <asn:2>*base
> 
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> 
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
> 
>  drivers/mtd/spi-nor/intel-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index e43ce63..986a3d0 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
>  
>  	ispi->base = devm_ioremap_resource(dev, mem);
>  	if (IS_ERR(ispi->base))
> -		return ispi->base;
> +		return ERR_CAST(ispi->base);
>  
>  	ispi->dev = dev;
>  	ispi->info = info;