* [PATCH] spi-nor: use ERR_CAST in return
@ 2017-02-12 16:43 Nicholas Mc Guire
2017-02-12 21:45 ` Boris Brezillon
0 siblings, 1 reply; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-12 16:43 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Marek Vasut, David Woodhouse, Brian Norris, Boris Brezillon,
Richard Weinberger, linux-mtd, linux-kernel, Nicholas Mc Guire
This fixes a sparse warning about
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
sparse complained about:
drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
Patch is against 4.10-rc6 (localversion-next is next-20170210)
drivers/mtd/spi-nor/intel-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index e43ce63..986a3d0 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
ispi->base = devm_ioremap_resource(dev, mem);
if (IS_ERR(ispi->base))
- return ispi->base;
+ return ERR_CAST(ispi->base);
ispi->dev = dev;
ispi->info = info;
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] spi-nor: use ERR_CAST in return
2017-02-12 16:43 [PATCH] spi-nor: use ERR_CAST in return Nicholas Mc Guire
@ 2017-02-12 21:45 ` Boris Brezillon
2017-02-12 22:04 ` Boris Brezillon
0 siblings, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2017-02-12 21:45 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel
On Sun, 12 Feb 2017 17:43:43 +0100
Nicholas Mc Guire <der.herr@hofr.at> wrote:
> This fixes a sparse warning about
Your commit message seems to be incomplete.
Once fixed,
Acked-by: Boris Brezillon <boris.brezilon@free-electrons.com>
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> sparse complained about:
> drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
> drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
> drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
>
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
>
> drivers/mtd/spi-nor/intel-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index e43ce63..986a3d0 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
>
> ispi->base = devm_ioremap_resource(dev, mem);
> if (IS_ERR(ispi->base))
> - return ispi->base;
> + return ERR_CAST(ispi->base);
>
> ispi->dev = dev;
> ispi->info = info;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi-nor: use ERR_CAST in return
2017-02-12 21:45 ` Boris Brezillon
@ 2017-02-12 22:04 ` Boris Brezillon
2017-02-13 7:35 ` Nicholas Mc Guire
0 siblings, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2017-02-12 22:04 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
+Mika
On Sun, 12 Feb 2017 22:45:43 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Sun, 12 Feb 2017 17:43:43 +0100
> Nicholas Mc Guire <der.herr@hofr.at> wrote:
>
> > This fixes a sparse warning about
>
> Your commit message seems to be incomplete.
And here too, please change the prefix to "mtd: spi-nor: intel: ".
Thanks,
Boris
>
> Once fixed,
>
> Acked-by: Boris Brezillon <boris.brezilon@free-electrons.com>
>
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> > ---
> >
> > sparse complained about:
> > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
> > drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
> > drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
> >
> > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> >
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> >
> > drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > index e43ce63..986a3d0 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
> >
> > ispi->base = devm_ioremap_resource(dev, mem);
> > if (IS_ERR(ispi->base))
> > - return ispi->base;
> > + return ERR_CAST(ispi->base);
> >
> > ispi->dev = dev;
> > ispi->info = info;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi-nor: use ERR_CAST in return
2017-02-12 22:04 ` Boris Brezillon
@ 2017-02-13 7:35 ` Nicholas Mc Guire
2017-02-13 7:53 ` Boris Brezillon
0 siblings, 1 reply; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-13 7:35 UTC (permalink / raw)
To: Boris Brezillon
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote:
> +Mika
>
> On Sun, 12 Feb 2017 22:45:43 +0100
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
> > On Sun, 12 Feb 2017 17:43:43 +0100
> > Nicholas Mc Guire <der.herr@hofr.at> wrote:
> >
> > > This fixes a sparse warning about
> >
> > Your commit message seems to be incomplete.
>
> And here too, please change the prefix to "mtd: spi-nor: intel: ".
>
What Im doing for checking prefix is:
hofrat@debian:~/git/linux-next$ git log --oneline drivers/mtd/spi-nor/intel-spi.c
8afda8b spi-nor: Add support for Intel SPI serial flash controller
is the method of checking the commit prefix with git log --oneline inapropriate ? How would I have found the "mtd: spi-nor: intel:" in this case ?
thx!
ohfrat
> >
> > Once fixed,
> >
> > Acked-by: Boris Brezillon <boris.brezilon@free-electrons.com>
> >
> > >
> > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> > > ---
> > >
> > > sparse complained about:
> > > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
> > > drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
> > > drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
> > >
> > > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> > >
> > > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > >
> > > drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > > index e43ce63..986a3d0 100644
> > > --- a/drivers/mtd/spi-nor/intel-spi.c
> > > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
> > >
> > > ispi->base = devm_ioremap_resource(dev, mem);
> > > if (IS_ERR(ispi->base))
> > > - return ispi->base;
> > > + return ERR_CAST(ispi->base);
> > >
> > > ispi->dev = dev;
> > > ispi->info = info;
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi-nor: use ERR_CAST in return
2017-02-13 7:35 ` Nicholas Mc Guire
@ 2017-02-13 7:53 ` Boris Brezillon
2017-02-13 7:59 ` Nicholas Mc Guire
0 siblings, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2017-02-13 7:53 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
On Mon, 13 Feb 2017 07:35:52 +0000
Nicholas Mc Guire <der.herr@hofr.at> wrote:
> On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote:
> > +Mika
> >
> > On Sun, 12 Feb 2017 22:45:43 +0100
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> >
> > > On Sun, 12 Feb 2017 17:43:43 +0100
> > > Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > >
> > > > This fixes a sparse warning about
> > >
> > > Your commit message seems to be incomplete.
> >
> > And here too, please change the prefix to "mtd: spi-nor: intel: ".
> >
>
> What Im doing for checking prefix is:
> hofrat@debian:~/git/linux-next$ git log --oneline drivers/mtd/spi-nor/intel-spi.c
> 8afda8b spi-nor: Add support for Intel SPI serial flash controller
>
> is the method of checking the commit prefix with git log --oneline inapropriate ?
It's appropriate, except in this case. You're referring to the commit
introducing a new driver, so this is expected to not find the
'intel:' suffix, but you have 'Add support for Intel SPI serial flash
controller' to clarify the scope.
Regarding the "mtd: " prefix, I think it's better to have it, but
apparently Cyrille is not enforcing that.
> How would I have found the "mtd: spi-nor: intel:" in this case ?
Well, it's a mix of common sense and 'git log --oneline' use :-). Here
you're only modifying the intel driver, but nothing in your subject
mentions it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi-nor: use ERR_CAST in return
2017-02-13 7:53 ` Boris Brezillon
@ 2017-02-13 7:59 ` Nicholas Mc Guire
0 siblings, 0 replies; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-13 7:59 UTC (permalink / raw)
To: Boris Brezillon
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
On Mon, Feb 13, 2017 at 08:53:11AM +0100, Boris Brezillon wrote:
> On Mon, 13 Feb 2017 07:35:52 +0000
> Nicholas Mc Guire <der.herr@hofr.at> wrote:
>
> > On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote:
> > > +Mika
> > >
> > > On Sun, 12 Feb 2017 22:45:43 +0100
> > > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > >
> > > > On Sun, 12 Feb 2017 17:43:43 +0100
> > > > Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > > >
> > > > > This fixes a sparse warning about
> > > >
> > > > Your commit message seems to be incomplete.
> > >
> > > And here too, please change the prefix to "mtd: spi-nor: intel: ".
> > >
> >
> > What Im doing for checking prefix is:
> > hofrat@debian:~/git/linux-next$ git log --oneline drivers/mtd/spi-nor/intel-spi.c
> > 8afda8b spi-nor: Add support for Intel SPI serial flash controller
> >
> > is the method of checking the commit prefix with git log --oneline inapropriate ?
>
> It's appropriate, except in this case. You're referring to the commit
> introducing a new driver, so this is expected to not find the
> 'intel:' suffix, but you have 'Add support for Intel SPI serial flash
> controller' to clarify the scope.
>
> Regarding the "mtd: " prefix, I think it's better to have it, but
> apparently Cyrille is not enforcing that.
>
> > How would I have found the "mtd: spi-nor: intel:" in this case ?
>
> Well, it's a mix of common sense and 'git log --oneline' use :-). Here
> you're only modifying the intel driver, but nothing in your subject
> mentions it.
got it (maybe) - thanks!
hofrat
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-13 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-12 16:43 [PATCH] spi-nor: use ERR_CAST in return Nicholas Mc Guire
2017-02-12 21:45 ` Boris Brezillon
2017-02-12 22:04 ` Boris Brezillon
2017-02-13 7:35 ` Nicholas Mc Guire
2017-02-13 7:53 ` Boris Brezillon
2017-02-13 7:59 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox