* [PATCH] spi-nor: use true/false for bool
@ 2017-02-12 16:43 Nicholas Mc Guire
2017-02-12 21:50 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Nicholas Mc Guire @ 2017-02-12 16:43 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Marek Vasut, David Woodhouse, Brian Norris, Boris Brezillon,
Richard Weinberger, linux-mtd, linux-kernel, Nicholas Mc Guire
writeable in struct intel_spi is a boolean and assignment should be to
true/false not 1/0 as recommended by boolinit.cocci.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
make coccicheck complained with:
./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
Patch is against 4.10-rc6 (localversion-next is next-20170210)
drivers/mtd/spi-nor/intel-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index a10f602..e43ce63 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
* whole partition read-only to be on the safe side.
*/
if (intel_spi_is_protected(ispi, base, limit))
- ispi->writeable = 0;
+ ispi->writeable = false;
end = (limit << 12) + 4096;
if (end > part->size)
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] spi-nor: use true/false for bool
2017-02-12 16:43 [PATCH] spi-nor: use true/false for bool Nicholas Mc Guire
@ 2017-02-12 21:50 ` Boris Brezillon
2017-02-12 22:01 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-02-12 21:50 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel
On Sun, 12 Feb 2017 17:43:31 +0100
Nicholas Mc Guire <der.herr@hofr.at> wrote:
> writeable in struct intel_spi is a boolean and assignment should be to
> true/false not 1/0 as recommended by boolinit.cocci.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>
> make coccicheck complained with:
> ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
>
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
>
> drivers/mtd/spi-nor/intel-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index a10f602..e43ce63 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> * whole partition read-only to be on the safe side.
> */
> if (intel_spi_is_protected(ispi, base, limit))
> - ispi->writeable = 0;
> + ispi->writeable = false;
>
> end = (limit << 12) + 4096;
> if (end > part->size)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi-nor: use true/false for bool
2017-02-12 21:50 ` Boris Brezillon
@ 2017-02-12 22:01 ` Boris Brezillon
2017-02-13 7:37 ` Nicholas Mc Guire
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-02-12 22:01 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
+Mika
On Sun, 12 Feb 2017 22:50:44 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Sun, 12 Feb 2017 17:43:31 +0100
> Nicholas Mc Guire <der.herr@hofr.at> wrote:
>
> > writeable in struct intel_spi is a boolean and assignment should be to
> > true/false not 1/0 as recommended by boolinit.cocci.
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
As asked in my other review, please use the 'mtd: spi-nor: intel'
prefix (or anything that would clarify the scope of this patch, like
'mtd: spi-nor/intel: ').
Thanks,
Boris
>
> > ---
> >
> > make coccicheck complained with:
> > ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
> >
> > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> >
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> >
> > drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > index a10f602..e43ce63 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> > * whole partition read-only to be on the safe side.
> > */
> > if (intel_spi_is_protected(ispi, base, limit))
> > - ispi->writeable = 0;
> > + ispi->writeable = false;
> >
> > end = (limit << 12) + 4096;
> > if (end > part->size)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi-nor: use true/false for bool
2017-02-12 22:01 ` Boris Brezillon
@ 2017-02-13 7:37 ` Nicholas Mc Guire
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas Mc Guire @ 2017-02-13 7:37 UTC (permalink / raw)
To: Boris Brezillon
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse, Brian Norris,
Richard Weinberger, linux-mtd, linux-kernel, Mika Westerberg
On Sun, Feb 12, 2017 at 11:01:44PM +0100, Boris Brezillon wrote:
> +Mika
>
> On Sun, 12 Feb 2017 22:50:44 +0100
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
> > On Sun, 12 Feb 2017 17:43:31 +0100
> > Nicholas Mc Guire <der.herr@hofr.at> wrote:
> >
> > > writeable in struct intel_spi is a boolean and assignment should be to
> > > true/false not 1/0 as recommended by boolinit.cocci.
> > >
> > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> As asked in my other review, please use the 'mtd: spi-nor: intel'
> prefix (or anything that would clarify the scope of this patch, like
> 'mtd: spi-nor/intel: ').
>
yup - will fix it up - just not yet clear how
to find the proper prefix next time - the method I
had been using seems insufficient.
thx!
hofrat
>
> >
> > > ---
> > >
> > > make coccicheck complained with:
> > > ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
> > >
> > > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> > >
> > > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > >
> > > drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > > index a10f602..e43ce63 100644
> > > --- a/drivers/mtd/spi-nor/intel-spi.c
> > > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> > > * whole partition read-only to be on the safe side.
> > > */
> > > if (intel_spi_is_protected(ispi, base, limit))
> > > - ispi->writeable = 0;
> > > + ispi->writeable = false;
> > >
> > > end = (limit << 12) + 4096;
> > > if (end > part->size)
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-13 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-12 16:43 [PATCH] spi-nor: use true/false for bool Nicholas Mc Guire
2017-02-12 21:50 ` Boris Brezillon
2017-02-12 22:01 ` Boris Brezillon
2017-02-13 7:37 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox