From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cg8lE-0001hj-8t for linux-mtd@lists.infradead.org; Tue, 21 Feb 2017 11:37:39 +0000 Date: Tue, 21 Feb 2017 12:37:04 +0100 From: Alexandre Belloni To: Logan Gunthorpe Cc: Greg Kroah-Hartman , Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Hans Verkuil , Mauro Carvalho Chehab , Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Matt Porter , Alexandre Bounine , Andrew Morton , Joe Perches , Lorenzo Stoakes , Vladimir Zapolskiy , Alessandro Zummo , Boaz Harrosh , Benny Halevy , "James E.J. Bottomley" , "Martin K. Petersen" , Stephen Bates , Bjorn Helgaas , linux-pci@vger.kernel.org, osd-dev@open-osd.org, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-mtd@lists.infradead.org, linux-media@vger.kernel.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function Message-ID: <20170221113704.ibwkk2vuc5imkmae@piout.net> References: <1487653253-11497-1-git-send-email-logang@deltatee.com> <1487653253-11497-3-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487653253-11497-3-git-send-email-logang@deltatee.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, A small comment, you must always have a commit message. Even if it is small. On 20/02/2017 at 22:00:41 -0700, Logan Gunthorpe wrote: > Signed-off-by: Logan Gunthorpe > --- > drivers/dax/dax.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c > index ed758b7..0d24822 100644 > --- a/drivers/dax/dax.c > +++ b/drivers/dax/dax.c > @@ -701,12 +701,12 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > > /* device_initialize() so cdev can reference kobj parent */ > device_initialize(dev); > + dev->devt = dev_t; > > cdev = &dax_dev->cdev; > cdev_init(cdev, &dax_fops); > cdev->owner = parent->driver->owner; > - cdev->kobj.parent = &dev->kobj; > - rc = cdev_add(&dax_dev->cdev, dev_t, 1); > + rc = device_add_cdev(dev, cdev); > if (rc) > goto err_cdev; > > @@ -716,7 +716,6 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > dax_dev->region = dax_region; > kref_get(&dax_region->kref); > > - dev->devt = dev_t; > dev->class = dax_class; > dev->parent = parent; > dev->groups = dax_attribute_groups; > -- > 2.1.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com