From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Richard Weinberger <richard@nod.at>,
Kumar Gala <galak@codeaurora.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wenyou Yang <wenyou.yang@atmel.com>,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Josh Wu <rainyfeeling@outlook.com>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>
Subject: Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver
Date: Tue, 21 Feb 2017 13:55:41 +0000 [thread overview]
Message-ID: <20170221135541.GV21222@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAHp75Vcb9gtzF7LvH74JwL4dTUyQvKmg=dnTXKfjhVHuyK3WXg@mail.gmail.com>
On Tue, Feb 21, 2017 at 01:02:21PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Tue, 21 Feb 2017 12:03:45 +0200
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> >> 1. For example,
> >>
> >> #define ATMEL_NFC_CMD(pos, cmd) ((cmd) <<
> >> (((pos) * 8) + 2))
> >
> > Well, I like to explicitly put parenthesis even when operator
> > precedence guarantees the order of the calculation ('*' is preceding
> > '+').
>
> That's my point. I'm not a LISP programmer.
> Personally I think it makes readability worse.
+1. I find unnecessary parenthesis is an effective obfuscation technique.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-02-21 13:56 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 12:28 [PATCH v2 0/3] mtd: nand: Rework/cleanup the Atmel NAND driver Boris Brezillon
2017-02-20 12:28 ` [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon
2017-02-20 20:27 ` Andy Shevchenko
2017-02-20 20:38 ` Boris Brezillon
2017-02-20 20:50 ` Boris Brezillon
2017-02-20 23:40 ` Andy Shevchenko
2017-02-20 23:54 ` Andy Shevchenko
2017-02-21 8:06 ` Boris Brezillon
2017-02-21 10:03 ` Andy Shevchenko
2017-02-21 10:26 ` Boris Brezillon
2017-02-21 10:46 ` Nicolas Ferre
2017-02-21 11:02 ` Andy Shevchenko
2017-02-21 11:20 ` Boris Brezillon
2017-02-21 13:47 ` Nicolas Ferre
2017-02-21 15:55 ` Andy Shevchenko
2017-02-21 16:12 ` Alexandre Belloni
2017-02-21 11:27 ` Alexandre Belloni
2017-02-21 16:09 ` Andy Shevchenko
2017-02-21 16:21 ` Alexandre Belloni
2017-02-21 16:32 ` Andy Shevchenko
2017-02-21 16:43 ` Andy Shevchenko
2017-02-21 17:14 ` Alexandre Belloni
2017-02-24 5:18 ` Håvard Skinnemoen
2017-02-24 8:14 ` Hans-Christian Noren Egtvedt
2017-02-24 8:27 ` Boris Brezillon
2017-02-24 8:52 ` Hans-Christian Noren Egtvedt
2017-02-24 8:55 ` Boris Brezillon
2017-02-24 9:04 ` Hans-Christian Noren Egtvedt
2017-02-24 9:21 ` Boris Brezillon
2017-02-24 9:51 ` Alexandre Belloni
2017-02-24 11:43 ` Andy Shevchenko
2017-03-01 8:22 ` Boris Brezillon
2017-03-01 8:38 ` Hans-Christian Noren Egtvedt
2017-03-01 8:49 ` Boris Brezillon
2017-02-24 9:28 ` Alexandre Belloni
2017-02-21 17:05 ` Alexandre Belloni
2017-02-21 13:55 ` Russell King - ARM Linux [this message]
2017-02-21 13:02 ` Nicolas Ferre
2017-02-20 12:28 ` [PATCH v2 2/3] mtd: nand: atmel: Document the new DT bindings Boris Brezillon
2017-02-21 13:11 ` Nicolas Ferre
2017-02-27 19:12 ` Rob Herring
2017-02-20 12:28 ` [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon
2017-03-07 12:04 ` Masahiro Yamada
2017-03-07 18:34 ` Boris Brezillon
2017-03-08 1:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221135541.GV21222@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.shevchenko@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=egtvedt@samfundet.no \
--cc=galak@codeaurora.org \
--cc=hskinnemoen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=rainyfeeling@outlook.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox